Add package.json css export #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added export './react-easy-crop.css' to library package.json
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 04d1cfc:
|
ValentinH
added
bug
|
Thank you for the fix and the detailed explanation. |
|
🚀 PR was released in |
|
Great ! Thanks for the quick merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the Pull Request
Problem
Using vite bundler in a monorepo setup with the
disableAutomaticStylesInjectionset to true, I was facing an issue where I couldn't import thereact-easy-crop.cssusing a reference to the package, likeimport 'react-easy-crop/react-easy-crop.css'. Instead I had to import this file from the node_modules, which is not ideal and actually break if the node_modules location change.Solution
Adding an export statement in the package.json to be able to import the
react-easy-crop.cssby referencing the package name.