Fix SSR onDestroy - ensure document before calling removeEventListener #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValentinH
approved these changes
Oct 28, 2022
ValentinH
reviewed
Oct 28, 2022
src/index.svelte
Outdated
| document.removeEventListener('mouseup', onDragStopped) | ||
| document.removeEventListener('touchmove', onTouchMove) | ||
| document.removeEventListener('touchend', onDragStopped) | ||
| if (document) { |
There was a problem hiding this comment.
You might want to even do typeof document !== 'undefined' actually because accessing the variable could even fail.
There was a problem hiding this comment.
Cheers, amended the commit
oscarhermoso
force-pushed
the
bugfix/ssr-ondestroy
branch
from
d3b3aeb
to
ef661d6
Compare
ValentinH
approved these changes
Oct 31, 2022
|
Thanks for the fix! This was released as https://github.com/ValentinH/svelte-easy-crop/releases/tag/v1.0.8 |
sanozie
pushed a commit
to sanozie/svelte-easy-crop
that referenced
this pull request
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #36