Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sveltekit to v2 along with its dependencies #50

Merged
merged 4 commits into from
Dec 22, 2023

Conversation

Davidonium
Copy link
Contributor

Tried using this library and since I recently bumped my project to sveltekit v2 I saw a warning, as seen in the issue #49.

This PR tries to solve the warning.

In the PR:

  1. There are bumps to @svelteks/kit v2 and its surrounding dependencies. (The svelte 3 to 4 bump required some additional work on the setup of eslint).
  2. Adds tabindex and role=button to avoid aria warnings to a div that was raising them.
  3. Fixes package publishing so that dependants on this package don't receive this warning: https://github.com/sveltejs/vite-plugin-svelte/blob/main/docs/faq.md#missing-exports-condition

I would need some help with the version bumping on the actual library. Also the e2e tests are failing because there's a small difference of subpixels in the image sizes.

Not sure how you work but I am open to change anything, hope this helps maintain the library.

@ValentinH
Copy link
Owner

Thank you for taking the time to submit this PR. 🎉

@ValentinH ValentinH merged commit b664864 into ValentinH:main Dec 22, 2023
3 checks passed
@ValentinH
Copy link
Owner

Published as svelte-easy-crop@2.0.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants