Skip to content

Commit

Permalink
Merge pull request #13 from ValentinVignal/upgrade-to-node-20
Browse files Browse the repository at this point in the history
Upgrade to node 20
  • Loading branch information
ValentinVignal committed Apr 25, 2024
2 parents daef594 + c4eb769 commit e9be154
Show file tree
Hide file tree
Showing 10 changed files with 28,404 additions and 7,680 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/cspell-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ jobs:
name: Code spelling
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Check spelling
uses: streetsidesoftware/cspell-action@v1
uses: streetsidesoftware/cspell-action@v6
8 changes: 4 additions & 4 deletions .github/workflows/linter.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ jobs:
name: Linter
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js 16
uses: actions/setup-node@v3
- uses: actions/checkout@v4
- name: Use Node.js 20
uses: actions/setup-node@v2
with:
node-version: 16
node-version: 20
- run: npm i
- name: eslint
# This is the name of the author of the github action.
Expand Down
10 changes: 6 additions & 4 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Install Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- run: npm install
- run: npm test
- name: Upload to Codecov
uses: codecov/codecov-action@v2
uses: codecov/codecov-action@v4
with:
# This is the name of the coverage reporter.
# cspell:ignore cobertura
files: ./coverage/clover.xml
token: ${{ secrets.CODECOV_TOKEN }}

4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.17

- :arrow_up: Upgrade to node 20.

## 0.16

- :sparkles: Supports nested analysis options.
Expand Down
24 changes: 10 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,22 +48,18 @@ No output.

## Result

It will fail the checks on your Pull Requests if any issue is found:
It will fail the checks on your Pull Requests if any issue is found:

![failed-workflow](https://github.com/ValentinVignal/action-dart-analyze/blob/main/doc/images/failed-workflow.png)

It will leave a comment explaining why it failed and what issues it found:

![comment](https://github.com/ValentinVignal/action-dart-analyze/blob/main/doc/images/comment.png)


In the code change, it will display errors and warnings where the issues are found:

![changes-warnings-errors](https://github.com/ValentinVignal/action-dart-analyze/blob/main/doc/images/changes-warnings-errors.png)




## Example usage

```yml
Expand All @@ -74,13 +70,13 @@ jobs:
runs-on: ubuntu-latest
name: Lint flutter code
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Flutter
uses: subosito/flutter-action@v2
- run: flutter pub get
- name: Analyze Flutter
uses: ValentinVignal/action-dart-analyze@v0.15
with:
fail-on: 'warning'
- name: Checkout code
uses: actions/checkout@v3
- name: Set up Flutter
uses: subosito/flutter-action@v2
- run: flutter pub get
- name: Analyze Flutter
uses: ValentinVignal/action-dart-analyze@v0.17
with:
fail-on: "warning"
```
2 changes: 1 addition & 1 deletion action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ inputs:
required: false

runs:
using: "node16"
using: "node20"
main: "dist/index.js"
Loading

0 comments on commit e9be154

Please sign in to comment.