Skip to content

Commit

Permalink
Merge pull request #3 from Vali0/feature/eslint
Browse files Browse the repository at this point in the history 
Feature/eslint
  • Loading branch information
@Vali0
Vali0 committed Jun 30, 2018
2 parents 8de8389 + 3da7ab7 commit ef91fb9
Show file tree
Hide file tree
Showing 11 changed files with 405 additions and 80 deletions.
281 changes: 281 additions & 0 deletions .eslintrc.js
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,281 @@
module.exports = {
"env": {
"es6": true,
"node": true
},
"globals": {
"after": true,
"afterEach": true,
"before": true,
"beforeEach": true,
"describe": true,
"it": true
},
"extends": "eslint:recommended",
"parserOptions": {
"sourceType": "module"
},
"rules": {
"accessor-pairs": "error",
"array-bracket-newline": "off",
"array-bracket-spacing": [
"error",
"never"
],
"array-callback-return": "error",
"array-element-newline": "off",
"arrow-body-style": "error",
"arrow-parens": "error",
"arrow-spacing": "error",
"block-scoped-var": "error",
"block-spacing": "error",
"brace-style": "error",
"callback-return": "error",
"camelcase": [
"error", {
"properties": "never"
}
],
"capitalized-comments": [
"error",
"always", {
"ignorePattern": "arrange|act|assert"
}
],
"class-methods-use-this": "error",
"comma-dangle": "off",
"comma-spacing": [
"error", {
"after": true,
"before": false
}
],
"comma-style": [
"error",
"last"
],
"complexity": "error",
"computed-property-spacing": [
"error",
"never"
],
"consistent-return": "error",
"consistent-this": "error",
"curly": "error",
"default-case": "error",
"dot-location": ["error", "property"],
"dot-notation": [
"error", {
"allowKeywords": true
}
],
"eol-last": [
"error",
"never"
],
"eqeqeq": "error",
"for-direction": "error",
"func-call-spacing": "error",
"func-name-matching": "error",
"func-names": [
"error",
"never"
],
"function-paren-newline": "error",
"generator-star-spacing": "error",
"getter-return": "error",
"global-require": "off",
"guard-for-in": "error",
"handle-callback-err": "error",
"id-blacklist": "error",
"id-length": [
"error", {
"properties": "never"
}
],
"id-match": "error",
"implicit-arrow-linebreak": "error",
"indent": "error",
"indent-legacy": "error",
"init-declarations": "off",
"jsx-quotes": "error",
"key-spacing": "error",
"keyword-spacing": "error",
"line-comment-position": "error",
"lines-around-comment": "error",
"lines-around-directive": "error",
"lines-between-class-members": "error",
"max-depth": "error",
"max-len": "off",
"max-lines": "off",
"max-nested-callbacks": "error",
"max-params": ["error", 5],
"max-statements": "off",
"max-statements-per-line": "error",
"multiline-comment-style": "error",
"multiline-ternary": "error",
"new-cap": "error",
"new-parens": "error",
"newline-after-var": "off",
"newline-before-return": "error",
"newline-per-chained-call": "error",
"no-alert": "error",
"no-array-constructor": "error",
"no-await-in-loop": "error",
"no-bitwise": "error",
"no-buffer-constructor": "error",
"no-caller": "error",
"no-catch-shadow": "error",
"no-confusing-arrow": "error",
"no-continue": "error",
"no-div-regex": "error",
"no-duplicate-imports": "error",
"no-else-return": "error",
"no-empty-function": "error",
"no-eq-null": "error",
"no-eval": "error",
"no-extend-native": "error",
"no-extra-bind": "error",
"no-extra-label": "error",
"no-extra-parens": "error",
"no-floating-decimal": "error",
"no-implicit-coercion": "error",
"no-implicit-globals": "error",
"no-implied-eval": "error",
"no-inline-comments": "error",
"no-iterator": "error",
"no-label-var": "error",
"no-labels": "error",
"no-lone-blocks": "error",
"no-lonely-if": "error",
"no-loop-func": "error",
"no-magic-numbers": "off",
"no-mixed-operators": "error",
"no-mixed-requires": "off",
"no-multi-assign": "error",
"no-multi-spaces": "error",
"no-multi-str": "error",
"no-multiple-empty-lines": "error",
"no-native-reassign": "error",
"no-negated-condition": "error",
"no-negated-in-lhs": "error",
"no-nested-ternary": "error",
"no-new": "off",
"no-new-func": "error",
"no-new-object": "error",
"no-new-require": "error",
"no-new-wrappers": "error",
"no-octal-escape": "error",
"no-param-reassign": "error",
"no-path-concat": "error",
"no-plusplus": "error",
"no-process-env": "error",
"no-process-exit": "error",
"no-proto": "error",
"no-prototype-builtins": "error",
"no-restricted-globals": "error",
"no-restricted-imports": "error",
"no-restricted-modules": "error",
"no-restricted-properties": "error",
"no-restricted-syntax": "error",
"no-return-assign": "error",
"no-return-await": "error",
"no-script-url": "error",
"no-self-compare": "error",
"no-sequences": "error",
"no-shadow": "error",
"no-shadow-restricted-names": "error",
"no-spaced-func": "error",
"no-sync": "error",
"no-tabs": "error",
"no-template-curly-in-string": "error",
"no-ternary": "error",
"no-throw-literal": "error",
"no-trailing-spaces": "error",
"no-undef-init": "error",
"no-undefined": "off",
"no-underscore-dangle": "off",
"no-unmodified-loop-condition": "error",
"no-unneeded-ternary": "error",
"no-unused-expressions": "off",
"no-use-before-define": ["error", {
"functions": false,
"classes": true,
"variables": true
}],
"no-useless-call": "error",
"no-useless-computed-key": "error",
"no-useless-concat": "error",
"no-useless-constructor": "error",
"no-useless-rename": "error",
"no-useless-return": "error",
"no-var": "error",
"no-void": "error",
"no-whitespace-before-property": "error",
"no-with": "error",
"nonblock-statement-body-position": "error",
"object-curly-newline": "off",
"object-curly-spacing": "error",
"object-property-newline": "error",
"object-shorthand": "off",
"one-var": "off",
"one-var-declaration-per-line": "error",
"operator-assignment": "error",
"operator-linebreak": "error",
"padded-blocks": "off",
"padding-line-between-statements": "error",
"prefer-arrow-callback": "off",
"prefer-const": "off",
"prefer-destructuring": "off",
"prefer-numeric-literals": "error",
"prefer-promise-reject-errors": "error",
"prefer-rest-params": "error",
"prefer-spread": "error",
"prefer-template": "error",
"quote-props": "off",
"quotes": "off",
"radix": "error",
"require-await": "error",
"require-jsdoc": "error",
"rest-spread-spacing": "error",
"semi": "error",
"semi-spacing": "error",
"semi-style": [
"error",
"last"
],
"sort-imports": "error",
"sort-keys": "off",
"sort-vars": "off",
"space-before-blocks": "error",
"space-before-function-paren": "off",
"space-in-parens": [
"error",
"never"
],
"space-infix-ops": "error",
"space-unary-ops": "error",
"spaced-comment": [
"error",
"always"
],
"strict": "error",
"switch-colon-spacing": "error",
"symbol-description": "error",
"template-curly-spacing": [
"error",
"never"
],
"template-tag-spacing": "error",
"unicode-bom": [
"error",
"never"
],
"valid-jsdoc": "error",
"vars-on-top": "error",
"wrap-iife": "error",
"wrap-regex": "error",
"yield-star-spacing": "error",
"yoda": "error"
}
};
5 changes: 5 additions & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ language: node_js
node_js:
- node
- lts/*

before_script:
- npm run lint

notifications:
email:
- mr.v.radev@gmail.com
Expand All @@ -10,4 +14,5 @@ notifications:
on_success: change # options: [always|never|change] default: always
on_failure: always # options: [always|never|change] default: always
on_start: never # options: [always|never|change] default: always

sudo: false
42 changes: 25 additions & 17 deletions lib/Bitbucket.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,19 @@ class Bitbucket {
});

return request(body)
.then(data => {
.then((data) => {
try {
let tokens = JSON.parse(data);

// TODO: Write new tokens in config file
this.accessToken = tokens['access_token'];
this.refreshToken = tokens['refresh_token'];
} catch (e) {
throw new Error('Cannot parse tokens. Stack trace: ' + e);
this.accessToken = tokens.access_token;
this.refreshToken = tokens.refresh_token;
} catch (err) {
throw new Error(`Cannot parse tokens. Stack trace: ${err}`);
}
})
.catch(err => {
throw new Error('Can not fetch client tokens. Stack trace: ' + err);
.catch((err) => {
throw new Error(`Can not fetch client tokens. Stack trace: ${err}`);
});
}

Expand All @@ -94,29 +94,37 @@ class Bitbucket {
});

return request(body)
.then(data => {
.then((data) => {
try {
let tokens = JSON.parse(data);

// TODO: Write new tokens in config file
this.accessToken = tokens['access_token'];
} catch (e) {
throw new Error('Cannot parse tokens. Stack trace: ' + e);
this.accessToken = tokens.access_token;
} catch (err) {
throw new Error(`Cannot parse tokens. Stack trace: ${err}`);
}
})
.catch(err => {
throw new Error('Can not refresh access token by given refresh: ' + this.refreshToken + '. Stack trace: ' + err);
.catch((err) => {
throw new Error(`Can not refresh access token by given refresh: ${this.refreshToken}. Stack trace: ${err}`);
});
}

// Append features to client object.
// Intention behind this idea is to make different calls with single instance of the client.
// e.g. request pull requests from different repositories with single client instance
/*
* Append features to client object.
* Intention behind this idea is to make different calls with single instance of the client.
* E.g. request pull requests from different repositories with single client instance
*/
pullRequests(username, repoSlug, options) {
return (new PullRequests(this, username, repoSlug, options));
return new PullRequests(this, username, repoSlug, options);
}
}

/**
* Builds request body for bitbucket by given configuration
*
* @param {Object} configuration - form body configuration
* @returns {String} options - Request body
*/
function buildRequestBody(configuration) {
let options = {
method: 'POST',
Expand Down

0 comments on commit ef91fb9

Please sign in to comment.