[READY] Bump Clang version in documentation #2445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.70% (diff: 100%)@@ master #2445 diff @@
==========================================
Files 17 17
Lines 1875 1875
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1532 1532
Misses 343 343
Partials 0 0
|
|
Glad it was this simple! :) Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks broke. Comments from Reviewable |
|
@homu r+ Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
📌 Commit e179e86 has been approved by |
homu
added a commit
that referenced
this pull request
Nov 22, 2016
[READY] Bump Clang version in documentation Since PR ycm-core/ycmd#590, Clang 3.9 is required because of the `KeepGoing` option. In fact, it is still possible to successfully compile against a 3.8 system libclang or with the `-DEXTERNAL_LIBCLANG_PATH` flag pointing to a 3.8 libclang since [the headers included in ycmd](https://github.com/Valloric/ycmd/tree/master/cpp/llvm/include/clang-c) are used in these two cases. However, the `KeepGoing` option will have no effect. So, we still recommend Clang 3.9 in all cases. Closes ycm-core/ycmd#654. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2445) <!-- Reviewable:end -->
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since PR ycm-core/ycmd#590, Clang 3.9 is required because of the
KeepGoingoption. In fact, it is still possible to successfully compile against a 3.8 system libclang or with the-DEXTERNAL_LIBCLANG_PATHflag pointing to a 3.8 libclang since the headers included in ycmd are used in these two cases. However, theKeepGoingoption will have no effect. So, we still recommend Clang 3.9 in all cases.Closes ycm-core/ycmd#654.
This change is