[READY] Do not fall back to default values in Clangd completer #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micbou
force-pushed
the
clangd-completer-user-options
branch
from
fe69bf4
to
f34309a
Compare
micbou
force-pushed
the
clangd-completer-user-options
branch
from
f34309a
to
e019b73
Compare
bstaletic
approved these changes
Dec 10, 2018
There was a problem hiding this comment.
Looks fine. Thanks for the PR.
Reviewed 3 of 3 files at r1.
Reviewable status: 1 of 2 LGTMs obtained
puremourning
approved these changes
Dec 10, 2018
complete! 2 of 2 LGTMs obtained
|
@zzbot r+ |
|
📌 Commit e019b73 has been approved by |
Codecov Report
@@ Coverage Diff @@
## master #1147 +/- ##
==========================================
- Coverage 97.61% 97.61% -0.01%
==========================================
Files 95 95
Lines 7342 7341 -1
==========================================
- Hits 7167 7166 -1
Misses 175 175 |
zzbot
added a commit
that referenced
this pull request
Dec 11, 2018
…rning [READY] Do not fall back to default values in Clangd completer We should only rely on the values set in the `ycmd/default_settings.json` file. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1147) <!-- Reviewable:end -->
|
💔 Test failed - status-appveyor |
|
@zzbot retry |
zzbot
added a commit
that referenced
this pull request
Dec 11, 2018
…rning [READY] Do not fall back to default values in Clangd completer We should only rely on the values set in the `ycmd/default_settings.json` file. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/1147) <!-- Reviewable:end -->
|
💔 Test failed - status-appveyor |
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only rely on the values set in the
ycmd/default_settings.jsonfile.This change is