[READY] Fixing issues with libs printing to stdout #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Details in source comment.
Valloric
changed the title
I couldn't agree more 😭 Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
|
I am so waiting for Python 4. @homu r+ Reviewed 1 of 1 files at r1. Comments from the review on Reviewable.io |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
📌 Commit b45d703 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Feb 20, 2016
[READY] Fixing issues with libs printing to stdout Details in source comment. This whole py2 -> py3 process has turned my dislike of dynamic languages into pure, unbridled hatred. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/379) <!-- Reviewable:end -->
Valloric
added a commit
that referenced
this pull request
Feb 20, 2016
The fix from #379 fixed py2, but broke py3. This fixes both and adds a test.
Valloric
added a commit
that referenced
this pull request
Feb 20, 2016
The fix from #379 fixed py2, but broke py3. This fixes both and adds a test.
Valloric
added a commit
that referenced
this pull request
Feb 20, 2016
The fix from #379 fixed py2, but broke py3. This fixes both and adds a test.
homu
added a commit
that referenced
this pull request
Feb 20, 2016
[READY] More fixes for printing with custom sys.stdout The fix from #379 fixed py2, but broke py3. This fixes both and adds a test. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/381) <!-- Reviewable:end -->
Valloric
added a commit
that referenced
this pull request
Feb 20, 2016
The fix from #379 fixed py2, but broke py3. This fixes both and adds a test.
homu
added a commit
that referenced
this pull request
Feb 20, 2016
[READY] More fixes for printing with custom sys.stdout The fix from #379 fixed py2, but broke py3. This fixes both and adds a test. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/381) <!-- Reviewable:end -->
Valloric
added a commit
that referenced
this pull request
Feb 20, 2016
The fix from #379 fixed py2, but broke py3. This fixes both and adds a test.
homu
added a commit
that referenced
this pull request
Feb 20, 2016
[READY] More fixes for printing with custom sys.stdout The fix from #379 fixed py2, but broke py3. This fixes both and adds a test. <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/381) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details in source comment.
This whole py2 -> py3 process has turned my dislike of dynamic languages into pure, unbridled hatred.