Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Switch back to GCC on Linux Travis #514

Merged
merged 1 commit into from
Jun 3, 2016
Merged

[READY] Switch back to GCC on Linux Travis #514

merged 1 commit into from
Jun 3, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jun 3, 2016 •
edited by Valloric
Loading

Since LLVM APT repository is not available anymore and we were using it to install Clang and build ycmd with it, we go back to GCC to make the tests pass again on Linux.

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.965% when pulling 3952af5 on micbou:travis-gcc into 65f1987 on Valloric:master.

@vheon
Copy link
Contributor

vheon commented Jun 3, 2016

:lgtm:

Previously, coveralls wrote…

Coverage Status

Coverage remained the same at 84.965% when pulling 3952af5 on micbou:travis-gcc into 65f1987 on Valloric:master.

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@Valloric
Copy link
Member

Valloric commented Jun 3, 2016

Thanks!

@homu r+

@homu
Copy link
Contributor

homu commented Jun 3, 2016

📌 Commit 3952af5 has been approved by Valloric

@homu
Copy link
Contributor

homu commented Jun 3, 2016

⚡ Test exempted - status

@homu homu merged commit 3952af5 into ycm-core:master Jun 3, 2016
homu added a commit that referenced this pull request Jun 3, 2016
@homu
Auto merge of #514 - micbou:travis-gcc, r=Valloric
d2b9873 
[READY] Switch back to GCC on Linux Travis

Since [LLVM APT repository is not available anymore](http://lists.llvm.org/pipermail/llvm-dev/2016-May/100303.html) and we were using it to install Clang and build ycmd with it, we go back to GCC to make the tests pass again on Linux.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/514)
<!-- Reviewable:end -->
@micbou micbou deleted the travis-gcc branch June 4, 2016 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@micbou @coveralls @vheon @Valloric @homu