Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health Bar #53

Merged
merged 18 commits into from
Oct 11, 2023
Merged

Health Bar #53

merged 18 commits into from
Oct 11, 2023

Conversation

Fotonnn
Copy link
Contributor

@Fotonnn Fotonnn commented Oct 8, 2023

it should work now

@Fotonnn Fotonnn changed the title Health Bars (Incomplete) Health Bar Oct 9, 2023
@WolverinDEV
Copy link
Collaborator

Hey,
thanks for your contribution.
The build currently fails with: https://github.com/Valthrun/Valthrun/actions/runs/6452169716/job/17524580048?pr=53

@Fotonnn
Copy link
Contributor Author

Fotonnn commented Oct 9, 2023

Hey, i've formatted the entire code, and it should work now.

@WolverinDEV
Copy link
Collaborator

Hey,
it's a cool pr, but there seems to be a little issue with the rendering:
image

I would also suggest, to copy the alpha value of the player 2d rectangle.

@Fotonnn
Copy link
Contributor Author

Fotonnn commented Oct 9, 2023

Hey, it's a cool pr, but there seems to be a little issue with the rendering: image

I would also suggest, to copy the alpha value of the player 2d rectangle.

Yeah im trying to solve this rn, and thx for the suggestion.

controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
Fotonnn added a commit to Fotonnn/Valthrun that referenced this pull request Oct 10, 2023
Fotonnn added a commit to Fotonnn/Valthrun that referenced this pull request Oct 10, 2023
Fotonnn added a commit to Fotonnn/Valthrun that referenced this pull request Oct 10, 2023
Fotonnn added a commit to Fotonnn/Valthrun that referenced this pull request Oct 10, 2023
@Fotonnn
Copy link
Contributor Author

Fotonnn commented Oct 10, 2023

Hey, it's a cool pr, but there seems to be a little issue with the rendering: image

I would also suggest, to copy the alpha value of the player 2d rectangle.

Solved! Thanks for the suggestion to use add_rect!
4429141

image

Copy link
Collaborator

@WolverinDEV WolverinDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks way better now, but there is still a visual bug 😆
image

controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/view/world.rs Outdated Show resolved Hide resolved
controller/src/settings/config.rs Outdated Show resolved Hide resolved
@Fotonnn
Copy link
Contributor Author

Fotonnn commented Oct 10, 2023

It looks way better now, but there is still a visual bug 😆 image

Hey, its solved, and thanks for the review.
image

@WolverinDEV WolverinDEV merged commit 32afe88 into Valthrun:master Oct 11, 2023
WolverinDEV pushed a commit that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants