Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local player spectator list. Defuse kit identificator. #62

Merged
merged 19 commits into from
Oct 11, 2023
Merged

Local player spectator list. Defuse kit identificator. #62

merged 19 commits into from
Oct 11, 2023

Conversation

PetrSeifert
Copy link
Contributor

Spectator_list
image

@nkxingxh
Copy link
Contributor

Maybe it would be better not to submit the ".idea" directory?

@PetrSeifert
Copy link
Contributor Author

Would it be fine, if I put it in .gitignore?

@WolverinDEV
Copy link
Collaborator

Would it be fine, if I put it in .gitignore?

Yes

WolverinDEV
WolverinDEV requested changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@WolverinDEV WolverinDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR, love seeing the spectator list implemented :)

controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/enhancements/player.rs Outdated Show resolved Hide resolved
controller/src/enhancements/spectators_list.rs Show resolved Hide resolved
controller/src/enhancements/spectators_list.rs Outdated Show resolved Hide resolved
@PetrSeifert
Copy link
Contributor Author

Should I make it so it also shows spectators list for the player you are spectating?

@WolverinDEV
Copy link
Collaborator

Should I make it so it also shows spectators list for the player you are spectating?

Well that would be the carry on top :D
Back in CS:GO days I did that as well :)

@WolverinDEV WolverinDEV merged commit 8286a6c into Valthrun:master Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolverinDEV WolverinDEV WolverinDEV requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@PetrSeifert @nkxingxh @WolverinDEV