Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing weapon IDs. #81

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Added missing weapon IDs. #81

merged 13 commits into from
Oct 16, 2023

Conversation

PetrSeifert
Copy link
Contributor

Resolves #80

@PetrSeifert PetrSeifert changed the title Added MP5-SD into weapons. Added missing weapon IDs. Oct 14, 2023
@PetrSeifert PetrSeifert marked this pull request as draft October 14, 2023 08:11
@WolverinDEV
Copy link
Collaborator

Hey, is there a reason why this is still a draft?

@PetrSeifert
Copy link
Contributor Author

I can check for other missing things. For example healthshot is still missing, there could be more of it. Or are you happy with this?

@WolverinDEV
Copy link
Collaborator

I can check for other missing things. For example healthshot is still missing, there could be more of it. Or are you happy with this?

Oh, that would be awesome!
I had a quite old list on which I based my weapon list.
I were to lazy to create a new dump :D

@peyman47
Copy link

I can check for other missing things. For example healthshot is still missing, there could be more of it. Or are you happy with this?

found healthshot

@PetrSeifert
Copy link
Contributor Author

I have it.

@PetrSeifert PetrSeifert marked this pull request as ready for review October 14, 2023 12:57
WolverinDEV
WolverinDEV reviewed Oct 15, 2023
View reviewed changes
Copy link
Collaborator

@WolverinDEV WolverinDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one, just rename M4A1 to M4A4 as well and we're ready to go :)

controller/src/weapon.rs Outdated Show resolved Hide resolved
@WolverinDEV WolverinDEV merged commit 8aabc2e into Valthrun:master Oct 16, 2023
1 check passed
@PetrSeifert PetrSeifert deleted the Added_MP5-SD_into_weapons branch October 17, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WolverinDEV WolverinDEV WolverinDEV left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

weapons id
3 participants
@PetrSeifert @WolverinDEV @peyman47