Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold enable Trigger bot #86

Merged
merged 7 commits into from
Oct 18, 2023
Merged

Hold enable Trigger bot #86

merged 7 commits into from
Oct 18, 2023

Conversation

nkxingxh
Copy link
Contributor

No description provided.

Copy link
Collaborator

@WolverinDEV WolverinDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the addition of BUILD_TIME, well done!

In regards of hold_enable_trigger_bot, I'm not sure what exactly sure, what you wanted to achieve. The name would suggest, that the trigger bot is only active while holding (down) a key but the implementation suggest your trigger bot is always active (without the need of holding the trigger key).
According to the implementation a more suited name would be "trigger_bot_always_active".

@nkxingxh
Copy link
Contributor Author

I really like the addition of BUILD_TIME, well done!

In regards of hold_enable_trigger_bot, I'm not sure what exactly sure, what you wanted to achieve. The name would suggest, that the trigger bot is only active while holding (down) a key but the implementation suggest your trigger bot is always active (without the need of holding the trigger key). According to the implementation a more suited name would be "trigger_bot_always_active".

Already changed

WolverinDEV added a commit that referenced this pull request Oct 18, 2023
@WolverinDEV WolverinDEV merged commit 22b996a into Valthrun:master Oct 18, 2023
1 check passed
@nkxingxh nkxingxh deleted the improve branch October 18, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants