Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto_fill_from_dict() will raises due to map returning iterable in py3 #56

Closed
rossengeorgiev opened this issue Nov 28, 2016 · 0 comments
Closed

proto_fill_from_dict() will raises due to map returning iterable in py3 #56

rossengeorgiev opened this issue Nov 28, 2016 · 0 comments
Labels
bug python3

Comments

@rossengeorgiev
Copy link
Contributor

Details in: ValvePython/dota2#15

   File "/usr/local/lib/python3.4/dist-packages/steam/util/__init__.py", line 99, in proto_fill_from_dict
     repr(key), type(val)
TypeError: Expected 'games_played' to be of type list, got <class 'map'>
rossengeorgiev added a commit that referenced this issue Nov 28, 2016
@rossengeorgiev
refactor proto_fill_from_dict & proto_to_dict; #56
17eac0c 
* added tests for both function
* both function now support py3 iterators types like map, range, filter
* proto_fill_from_dict will correctly overwrite lists when clear=False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug python3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rossengeorgiev