-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oauth login functionality #211
Conversation
If I understand this correctly, once I login with mobileauth (user+pass etc) I get |
Yes; once you have a token, you can use it until it gets revoked (which seems to be random). Then, you must get a new one, which does require the username and password. The |
Thanks. I will need to try this out and figure out how this would fit in the class. Wondering whether it might better to implement it as a "remember password" feature. |
Sorry, this PR has been sitting for a while. Happy to merge |
Ah, sorry for the delay: I've rebased the branch onto master. Does anything else need to be done before merging? |
Alright, I've managed to fetch and confirm mobile confirmations w/o the |
Kudos, SonarCloud Quality Gate passed!
|
Because we have access to creating OAuth tokens, I thought it might be useful to use them to log in more easily. If any code style changes/refactoring needs to be done, I'd be happy to do it.