Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add _transfer_cookie method (webauth) #341

Closed
wants to merge 1 commit into from
Closed

add _transfer_cookie method (webauth) #341

wants to merge 1 commit into from

Conversation

hexiro
Copy link
Contributor

@hexiro hexiro commented Jun 23, 2021

Added a method called, _transfer_cookie which sets a cookie for the three main steam domains.
This method removes redundancy of repeating:
for domain in ['store.steampowered.com', 'help.steampowered.com', 'steamcommunity.com']:
by handling that with this method. Let me know what you think of this idea!

Copy link
Contributor

@rossengeorgiev rossengeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This servers no purpose besides adding another call to the stack for the sake of not repeating one thing twice. It taking DRY to an extreme. I think I must more reasonable thing would be to have the domains in variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants