-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional "binary" argument to a2s_rules function #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility because protobuf version 3.18 dropped 2.7 support
…bility because protobuf version 3.18 dropped 2.7 support
rossengeorgiev
requested changes
Sep 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few nitpicks, otherwise lgtm
@rossengeorgiev Back to you! Thanks! |
rossengeorgiev
approved these changes
Oct 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For your consideration, this PR resolves #358 by adding an optional
binary
argument to thea2s_rules
function. Please let me know if you would prefer a different solution.I have added a unit test for the new behavior, plus a basic "happy path" test covering
a2s_rules
when all optional arguments use their defaults, since thesteam.game_servers
module did not have any existing test coverage.It looks like this project has not yet dropped legacy Python support, so I have added an upper version limit to
protobuf
inrequirements.txt
andsetup.py
because version 3.18 dropped support for Python 2.7.Finally, the docs were erroneously reporting that the
a2s_rules
return type is alist
, so I have corrected this to report the type as adict
.