Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional "binary" argument to a2s_rules function #359

Merged
merged 9 commits into from
Oct 2, 2021

Conversation

tjensen
Copy link
Contributor

@tjensen tjensen commented Sep 25, 2021

For your consideration, this PR resolves #358 by adding an optional binary argument to the a2s_rules function. Please let me know if you would prefer a different solution.

I have added a unit test for the new behavior, plus a basic "happy path" test covering a2s_rules when all optional arguments use their defaults, since the steam.game_servers module did not have any existing test coverage.

It looks like this project has not yet dropped legacy Python support, so I have added an upper version limit to protobuf in requirements.txt and setup.py because version 3.18 dropped support for Python 2.7.

Finally, the docs were erroneously reporting that the a2s_rules return type is a list, so I have corrected this to report the type as a dict.

Copy link
Contributor

@rossengeorgiev rossengeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few nitpicks, otherwise lgtm

requirements.txt Outdated Show resolved Hide resolved
steam/game_servers.py Outdated Show resolved Hide resolved
@tjensen
Copy link
Contributor Author

tjensen commented Sep 25, 2021

@rossengeorgiev Back to you! Thanks!

setup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@rossengeorgiev rossengeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rossengeorgiev rossengeorgiev merged commit 7ddb7f3 into ValvePython:master Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to return a2s_rules as bytes instead of strings
2 participants