Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Try to use unittest.mock from the Python standard library #34

Merged
merged 1 commit into from
Feb 23, 2021

Conversation

smcv
Copy link
Contributor

@smcv smcv commented Feb 23, 2021

Only fall back to the standalone mock module if the Python version is
too old to have it in the standard library.

Copy link
Contributor

@rossengeorgiev rossengeorgiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... This just be accompanied by a condition in dev_requirements.txt for the mock dependency. Like python_version < 3.4

Only fall back to the standalone mock module if the Python version is
too old to have it in the standard library.

Signed-off-by: Simon McVittie <smcv@debian.org>
@smcv
Copy link
Contributor Author

smcv commented Feb 23, 2021

Yeah... This just be accompanied by a condition in dev_requirements.txt for the mock dependency. Like python_version < 3.4

Thanks, fixed.

@rossengeorgiev rossengeorgiev merged commit 2b23d5b into ValvePython:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants