Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196.
Before on the reported archive, there were millions of sampler objects. Memory usage exploded:
On a pruned archive, there is only 1 surviving sampler, so we get:
This is closer to what we normally expect as a high water mark per process.
With this PR, VkSamplers are only replayed if they are a dependency of a descriptor set layout. Unfortunately, we have a hard time knowing which samplers to record since we don't know at recording time if a sampler is part of a descriptor set layout. We don't want to bloat the runtime memory usage by holding onto an unbound number of samplers "just in case". I'll follow up with another PR to be able to ignore immutable samplers if we know the application (DXVK in this case) does not really make use of them.
This is far more reasonable, but the increased memory usage compared to pruned is the hashmap post-parse needs to holds millions of sampler references. Not recording millions of samplers will fix this as well down the line.