RFC: Disable esync when running the install script. #3240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Lesho <dlesho@codeweavers.com>
|
I don't know enough about esync. If it's esync's fault that Origin don't install, I think esync should be fixed . Or does it trigger a behavior that esync can't handle by design? |
|
https://bugs.winehq.org/show_bug.cgi?id=48089#c4 Yes , esync needs that to be implemented but there is no eta. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Origin fails to install/update when esync is enabled. We can work around this by disabling esync during the install script. If I'm not mistaken, wineserver is restarted before the game itself is run, so this should be safe. One concern though is how this would affect non-steam games run through Proton.