Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] showinfo command doesn't work because of key misspelling #3347

Open
AlphaDelta opened this issue Sep 7, 2020 · 1 comment
Open

[SDK] showinfo command doesn't work because of key misspelling #3347

AlphaDelta opened this issue Sep 7, 2020 · 1 comment

Comments

@AlphaDelta
Copy link

AlphaDelta commented Sep 7, 2020

The showinfo <type> <title> <message> command is broken on Counter Strike: Source, as well as TF2 it seems.

The issue exists because the command sets a key "message" in a KeyValue object seen here:
https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/client/game_controls/vguitextwindow.cpp#L58

...which is then passed to CTextWindow::SetData

However the CTextWindow::SetData method expects a key of "msg", not "message", as seen here:
https://github.com/ValveSoftware/source-sdk-2013/blob/0d8dceea4310fde5706b3ce1c70609d72a38efdf/mp/src/game/client/game_controls/vguitextwindow.cpp#L388

The outcome of which is a VGUI 'info' panel being spawned with a title but no contents.

@AlphaDelta AlphaDelta changed the title showinfo command doesn't work because of key misspelling [SDK] showinfo command doesn't work because of key misspelling Sep 7, 2020
@AlphaDelta
Copy link
Author

GamerDude27 added a commit to Nbc66/source-sdk-2013-ce that referenced this issue Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants