Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libdisplay-info now uses the right pc file name #823

Closed
colemickens opened this issue Mar 11, 2023 · 1 comment · Fixed by #824
Closed

libdisplay-info now uses the right pc file name #823

colemickens opened this issue Mar 11, 2023 · 1 comment · Fixed by #824

Comments

@colemickens
Copy link

Linking this as an example: nix-community/nixpkgs-wayland@6ca8943

The PC filename for pkg-config for libdisplay-info is now corrected.

I think that gamescope needs to adjust as well by updating src/meson.build to look for "libdisplay-info" so it picks up the PC file.
@colemickens
Copy link
Author

This fixes my build against libdisplay-info 0.1.1:

 sed -i "s/display-info/libdisplay-info/g" 'src/meson.build'

Also, AFAICT the changes I mentioned for openVR are still true: #752

Scrumplex added a commit to Scrumplex/gamescope that referenced this issue Mar 12, 2023
@Scrumplex
build: update libdisplay-info pkgconfig filename
4e418a8 
Fixes ValveSoftware#823

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
@Scrumplex Scrumplex mentioned this issue Mar 12, 2023
Merged
emersion pushed a commit that referenced this issue Mar 12, 2023
@Scrumplex @emersion
build: update libdisplay-info pkgconfig filename
5a672f0 
Fixes #823

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Samsagax pushed a commit to Samsagax/gamescope that referenced this issue May 26, 2023
@Scrumplex @Samsagax
build: update libdisplay-info pkgconfig filename
89e430a 
Fixes ValveSoftware#823

Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: update libdisplay-info pkgconfig filename Scrumplex/gamescope
1 participant
@colemickens