Hold client buffers, version 3 #77
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us keep the buffers for pending commits locked.
This will allow us to call wlr_buffer_lock/unlock in import_commit without causing a deadlock.
emersion
force-pushed
the
hold-buffers-v3
branch
from
7413310
to
b8ce89a
Compare
|
The Mesa MR has been merged: https://gitlab.freedesktop.org/mesa/mesa/-/commit/ec5e918ef4911d09b5611773bc58952b13ccef38 |
|
This is merged, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a re-do of #55
Need to wait for #74 to be fixed before this is merged, because it makes the freeze happen more often.