[Half-Life] Missing Localization Strings

[ghost]

Half-Life has missing localization strings in its spectator mode menu.

(Note how the selected mode is localized correctly, but not the menu list elements)

Spec_ModeN strings are referenced in the game's titles.txt file but it seems to have no effect.

(Line 742)

Spec_Mode1
{
Locked Chase-Camera
}

Spec_Mode2
{
Free Chase-Camera
}

Spec_Mode3
{
Free-Look
}

Spec_Mode4
{
First Person
}

Spec_Mode5
{
Free Map Overview
}

Spec_Mode6
{
Chase Map Overview
}

Valve_xxxx strings are referenced in the game's spectatormenu.txt file, but the localization strings are nowhere to be seen.
(line 23)

"5" "#Valve_Close" 	"spec_menu 0"

"4" "#Valve_Help"	"spec_help"

"3" "#Valve_Settings"
{	
	TOGGLE 	"4" "#Valve_Chat_Messages"	"hud_saytext"
	
	TOGGLE	"3" "#Valve_Show_Status"	"spec_drawstatus"
	
	TOGGLE	"2" "#Valve_View_Cone"		"spec_drawcone"
	
	TOGGLE	"1" "#Valve_Player_Names"	"spec_drawnames"
}

TOGGLE	"2" "#Valve_Auto_Director"	"spec_autodirector"
"1" "#Valve_Show_Score"	"togglescores"

#2316 references a Join Team VGUI menu, however, it also lacks localization strings.

[SamVanheer]

Duplicate of #2311

The buttons use different localization keys than the command menu files.

For example spectcammenu.txt uses #Spec_Mode6 but the code uses #OBS_MAP_CHASE.

The localization keys used for the options drop down exist in resource/valve_language.txt but those are only used by VGUI2 code. Looks like they'll need to be duplicated in titles.txt to work.

[mikela-valve]

@SamVanheer Actually this proved to go even deeper than the actual keys used by the buttons. The spectate GUI is VGUI1 not VGUI2, and as such the controls don't automatically localise themselves, so the buttons were just not having their text localised at all.

I've fixed that issue and added the missing settings strings to the titles.txt so this issue should be fixed in the next beta.

[mikela-valve]

This should be fixed in beta update '15:46:27 Jun 11 2019 (8265)'.

[ghost]

Tested it in Linux, works without problems so far. I will comment on this same issue if there are problems.

Thank you @mikela-valve!.