Snarks have their movetype changed to MOVETYPE_BOUNCE unconditionally when not in water

[SamVanheer]

The snark has an incorrect if statement here:

halflife/dlls/squeakgrenade.cpp

Lines 223 to 236 in c7240b9

	// float
	if (pev->waterlevel != 0)
	{
	if (pev->movetype == MOVETYPE_BOUNCE)
	{
	pev->movetype = MOVETYPE_FLY;
	}
	pev->velocity = pev->velocity * 0.9;
	pev->velocity.z += 8.0;
	}
	else if (pev->movetype = MOVETYPE_FLY)
	{
	pev->movetype = MOVETYPE_BOUNCE;
	}

This conditional check changes the value of the movetype to MOVETYPE_FLY and then immediately after that to MOVETYPE_BOUNCE.

The intended behavior of this code is to restore the Snark's movetype to bounce when it leaves water, but only if its previous movetype was fly.

Although the Snark's behavior is still correct barring changes to the movetype from outside the Snark's code, this check should be fixed so modders can safely change the movetype without having to deal with this overriding behavior.

The fix:

else if (pev->movetype == MOVETYPE_FLY)
{
	pev->movetype = MOVETYPE_BOUNCE;
}

[SamVanheer]

This also applies to Opposing Force's Penguin grenade, since its code is a copy of the Snark.