Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MONEY BAR? #702

Closed
forran opened this issue Mar 4, 2013 · 166 comments
Closed

MONEY BAR? #702

forran opened this issue Mar 4, 2013 · 166 comments

Comments

@forran
Copy link

forran commented Mar 4, 2013

It would be nice to have player moneys shown in TAB as it is in CS:GO.

@MrSchism
Copy link
Member

MrSchism commented Mar 4, 2013

I assume that you're suggesting this for CS1.6?

@kbloo
Copy link

kbloo commented Mar 4, 2013

I think that would be nice.

@idderf
Copy link

idderf commented Mar 4, 2013

+1, it saves alot of time for the IGL when he doesn't have to request everyone to type money at the beginning of a round....

@ghost
Copy link

ghost commented Mar 4, 2013

better if there was a server-side cvar sv_teammoney or something
0 - do not show player money for both
1 - show player money only for his team mate's (your team does not see your enemy's money)
2 - show player money for both enemy and ally (your team does see enemy's money)

@ghost ghost self-assigned this Mar 4, 2013
@kbloo
Copy link

kbloo commented Mar 4, 2013

Exactly KirVs.

I have a amx plugin that works but sometimes shows only 2 or 3 players money. It sucks. :(

@Rst-7
Copy link

Rst-7 commented Mar 4, 2013

to Valve. Please tell me all the launch options CS1.6. Or where it can be viewed.

@ghost
Copy link

ghost commented Mar 4, 2013

@Rst-7 I belive Valve keeps its secrets
But you can find some commands here: https://developer.valvesoftware.com/wiki/Command_Line_Options

@Rst-7
Copy link

Rst-7 commented Mar 4, 2013

@Maxkorz
thanks

@Rst-7
Copy link

Rst-7 commented Mar 4, 2013

@Maxkorz
| -refresh or -refreshrate or -freq - Force a specific refresh rate. Ex: -refresh 60

Launch option "-refresh" left?

@ghost
Copy link

ghost commented Mar 4, 2013

@Rst-7 Yep. #380 (comment)
And you're looking at Source launch options, CS 1.6 uses GoldSource: https://developer.valvesoftware.com/wiki/Command_Line_Options#Goldsource_Games

@Rst-7
Copy link

Rst-7 commented Mar 4, 2013

@Maxkorz
That is, all of the parameters are only of Goldsource Games ? https://developer.valvesoftware.com/wiki/Command_Line_Options#Goldsource_Games
And those that Source Games no longer work? - https://developer.valvesoftware.com/wiki/Command_Line_Options#Source_Games

@MrSchism
Copy link
Member

MrSchism commented Mar 5, 2013

Lets try to keep the issues on-topic, please?

@kbloo
Copy link

kbloo commented Mar 5, 2013

"triage-valve is assigned"

Is this mean they are deciding what to do with the sugestion?

@MrSchism
Copy link
Member

MrSchism commented Mar 5, 2013

We'll leave you to speculate what that means. :trollface:

@ghost
Copy link

ghost commented Mar 5, 2013

sorry for off topping
@Rst-7 http://en.wikipedia.org/wiki/Goldsource became http://en.wikipedia.org/wiki/Source_engine
GoldSource launch options are for Gold Source games (Half-Life and mods, like Counter-Strike 1.6, CS:CZ, etc), Source engine = Half-Life2, etc

@Egon-Spengler
Copy link

Triage is the poor guy who works at Valve's basement, with a minimal quality computer running Windows 98, gets two semi-hot meals a day, codes 15 hours per day and calls Alfred "my lord".

Unfortunately, they don't let him post around here, they say he's kinda shy.

@forran
Copy link
Author

forran commented Mar 5, 2013

Yes i suggest it for 1.6

@idderf
Copy link

idderf commented Mar 5, 2013

@kirvs the only problem with making it a server side cvar is that most serveradmins nowadays don't update servers / don't care about new cvars. It would me much more efficient to just always show the team's money. It only affects competitive gameplay in a positive way, since it speeds up the IGL's tactical thinking.

@MrSchism
Copy link
Member

MrSchism commented Mar 6, 2013

@kirvs the only problem with making it a server side cvar is that most serveradmins nowadays don't update servers / don't care about new cvars. It would me much more efficient to just always show the team's money. It only affects competitive gameplay in a positive way, since it speeds up the IGL's tactical thinking.

Untrue. If it shows all money (including enemy team money), you can get an idea as to what gear has been purchased.

@idderf
Copy link

idderf commented Mar 6, 2013

@MrSchism since the main post referred to cs:go, in which you only see TEAMMATE money, a money bar would only be a positive thing

@MrSchism
Copy link
Member

MrSchism commented Mar 6, 2013

@MrSchism since the main post referred to cs:go, in which you only see TEAMMATE money, a money bar would only be a positive thing

While that's true, remember that early in the discussion, @kirvs brought up the idea of a cvar with three options, one of which being an option to show all money.

@kbloo
Copy link

kbloo commented Mar 8, 2013

Any news on this? We just wait on darkness? ^^

@idderf
Copy link

idderf commented May 17, 2013

Can you please implement this? At least so that you can see the money each player has on your team; would be great for competitive play =)

@kbloo
Copy link

kbloo commented May 17, 2013

I support this idea. Again.

@mikela-valve mikela-valve assigned mikela-valve and unassigned ghost Apr 18, 2019
@mikela-valve
Copy link
Member

Hi all, I've added this in the latest CS beta. You only see the money for members of your current team and only when you are a T or CT (i.e. spectators see nothing).

146CBBB1-4A95-4FFC-9858-F1D708948EF4

AF5207FC-165C-4D34-9C03-DD345B21EA7E

@RauliTop
Copy link

@mikela-valve
It's great, but it should have a server cvar to disable this feature.

For example, in some zombie servers or other mods that doesn't use money.

@Mistrick
Copy link

Mistrick commented Apr 20, 2019

@mikela-valve would be nice if amxx plugin(or metamod) can set own name for this column and set format.
Use like assist or money/assist with format $1000/4
Or create one more column for this.
Don't show full value in low res.
20190420184043_1

@afwn90cj93201nixr2e1re
Copy link

изображение
Then there no problems with aligment.
Just test it for first time in 640x480, if it's good, than another resolution's work's fine too.

Or:
изображение

Idk.
Old style table is better.

@10th
Copy link

10th commented Jun 22, 2019

The background of the current player's row is rather dim. Is it possible to slightly reduce the transparency or add juiciness to the color?

222

@CS-PRO1
Copy link

CS-PRO1 commented Jun 23, 2019

I guess I'm doing the icons now and they'll be based off the ones in the HUD.. I need to know 2+1 things:

  1. What color they should be?
  2. They should have actual transparent background or a pure blue/pink/green background?
  3. What is the size for each icon?
    @mikela-valve

@mikela-valve
Copy link
Member

The biggest issue to tackle I believe is making icons that will be quickly identifiable at the smaller line sizes used in <768 heights. Especially once you have >24 players on the server the line is quite tiny.

Probably the current HUD icons will be the most recognizable, so starting there would be best and keeping them similar to the green and transparency of the HUD will make them neutral in colour (i.e. not looking like a header or T/CT-specific) and will stand out in the row.

I'll have to check the line sizes to actually know what they are, I think they're proportionally set based on the font.

@mikela-valve
Copy link
Member

Update 8279 has a few changes in it.

@10th the header widths have been increased slightly so they shouldn't run so closely together. Also the player's highlight has been slightly intensified to make it more noticeable.

This update also enables avatars showing in <768 heights, so that dead space on the right of the scoreboard is finally used. I tested them at all of the different line sizes for different numbers of players but let me know if anything looks off.

@afwn90cj93201nixr2e1re
Copy link

afwn90cj93201nixr2e1re commented Jun 26, 2019

Especially once you have >24 players on the server the line is quite tiny.

avatar's same, but seems nice, Here no problems with size.

Keep same size's.
@mikela-valve

@10th
Copy link

10th commented Jun 26, 2019

@mikela-valve Cool, thank you!

scoreboard_show_avatars ? ;-)

@dager10
Copy link

dager10 commented Jun 26, 2019

my vision how scoretab need to look like with short abbreviation, $ - money, H - health, K - kills, D - deaths, L - latency (or P - ping). We also can show money without $ symbol.

scoretab

@afwn90cj93201nixr2e1re
Copy link

Not bad.
But on some server's hp can be more than 9999, and there is problem.
Coz on low resolution there no extra space for additional columns.

@dager10
Copy link

dager10 commented Jun 26, 2019

of course we can do less space between dead status and money and more space between money and health and I think 5 digits numbers will be display good enough for fields $, H, K, D, L, but need to test it

@CS-PRO1
Copy link

CS-PRO1 commented Jun 26, 2019

Would fonts work better instead of actual images? like CS:S for example..
I'll start working on icons tomorrow, hopefully I can finish by Monday..

@agrastiOs
Copy link

I think this is done honestly, all these are other feature suggestions that should be posted separately. What do you think @kisak-valve?

@afwn90cj93201nixr2e1re
Copy link

It's breakable change for low resolution's as you can see ( #702 (comment) ), we should provide more pleasant solution.
@agrastiOs

@Zetz512
Copy link

Zetz512 commented Jun 27, 2019

@afwn90cj93201nixr2e1re about the HP and the amount has the player, can add a cvar to change how you see the HP in value or in percentage like mp_healthscoreboard_mode or interpret values more than 999 like 1K - 100K - 1M - 100M

1K - 1.000 HP
1M - 1.000.000 HP

@afwn90cj93201nixr2e1re
Copy link

Now everything is fine, there many unnecessary cvar's from March update's.
We can get rid of them. If @mikela-valve gonna make some improvment's, xD.

@mikela-valve
Copy link
Member

@afwn90cj93201nixr2e1re Which cvar's are unnecessary? Also, are you still seeing issues with the columns like in #702 (comment)? The health and money columns should be stealing space from the name column, not pushing any of the other columns to the right.

@Splatt581
Copy link

  1. In the scoreboard, the health field is referred to as HP for short, regardless of the value of the cvar scoreboard_shortheaders. I suggest giving this field the full name Health, if scoreboard_shortheaders is 0.

de_dust0004
de_dust0005

  1. With mp_scoreboard_showmoney / showhealth 0, the server still sends HealthInfo and Account messages, but with empty fields. Is this normal server behavior? Sample packet below:

newmsgs

  1. When we first open the scoreboard, the avatars of the players slightly "jump" to the left. This happens at all resolutions:

avatar

@10th
Copy link

10th commented Jul 4, 2019

@Splatt581,
3. And this happens not only at the first opening, but also when new players enter, when their avatars are loaded.
Additionally I propose to make a little more space between the nickname and the avatar, for unicode characters in nicknames sometimes look close to the avatar.

@mikela-valve
Copy link
Member

mikela-valve commented Jul 5, 2019

Thanks @Splatt581 and @10th.

  1. I had the column labeled Health originally but switched to HP as a standard header label for it to standardize it across localizations, that is it will just be HP in all languages. That's why it's now HP both with scoreboard_shortheaders set and unset.

  2. Those messages are sent so that the clients know whether or not to show those fields, regardless of when the client connects rather than add or updates messages to set settings on the client. For simplicity the server just sends periodic updates at a low rate (every 5s or when values change) to prevent any weird edge case issues like stale values sticking around through a team change or a server cvar change or things like that. I did notice it was sending health/money updates when the value changed regardless of whether the real value was sent so I did change it to skip those updates and only send the periodic update in that case.

  3. Should be fixed in the next release, that column was being sized improperly when the
    scoreboard is first created then sized properly once a player update happens.

@afwn90cj93201nixr2e1re
Copy link

afwn90cj93201nixr2e1re commented Jul 6, 2019

Which cvar's are unnecessary?

Can you show new cvar list which include new cvar's from April for example?

Also, are you still seeing issues with the columns like in #702 (comment)?

I can't test it right now, but i wanna see Full column name's like in older cs version's with standart config, but without issue's with wide.

So, did you start making some new ico's for health/dead/bomb/vip etc? xD

@afwn90cj93201nixr2e1re
Copy link

@mikela-valve

@uniarch
Copy link

uniarch commented Jul 14, 2019

I think this needs to be closed. money bar is done and shows numbers correctly. you can format values above 99,999 as 100k,666k,1m,1b... but is pretty nice as it is, low resolutions are looking good.
I kindly ask mikela to do this release asap and begin to resolve #2154 , #12
The hitbox issue is one if not the most important issue and the one the community waits for a very long time.
And the second will open much greater possibilities for mappers and modders.

Please, don't hesitate with current release and make our dreams happen :3

@agrastiOs
Copy link

I agree this can be closed.

@uniarch
Copy link

uniarch commented Jul 15, 2019

I think this needs to be closed. money bar is done and shows numbers correctly. you can format values above 99,999 as 100k,666k,1m,1b... but is pretty nice as it is, low resolutions are looking good.
I kindly ask mikela to do this release asap and begin to resolve #2154 , #12
The hitbox issue is one if not the most important issue and the one the community waits for a very long time.
And the second will open much greater possibilities for mappers and modders.

Please, don't hesitate with current release and make our dreams happen :3

or if not closed then transferred to future release as too large :?

@CS-PRO1
Copy link

CS-PRO1 commented Jul 16, 2019

Yea I agree on releasing this as it is and having a new issue track for future/ongoing release.

@mikela-valve
Copy link
Member

Closing this as fixed. We should create a new issue to track additional work on the interface like the addition of icons.

@PartialCloning
Copy link

@mikela-valve when will we see this update officially? When is "Next Release"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests