Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input code fixes #1900

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dtugend
Copy link
Contributor

@dtugend dtugend commented Aug 25, 2018

I re-submit #1559 as this, since I didn't want this to sit on the "master" branch of our repository, which shall reflect the master of ValveSoftware/halflife instead.

Fixes #1546

  • fixed m_rawinput 1 mouse trapped inside a rectangle
  • fixed thirdperson camera not working as it should

Fixes #1558

  • recoded mousethread and made it somewhat useful for very fast mouse
    movements (will reset CursorPos now) and thus also fixed some thread
    synchronization issues (hopefully)

Further fixes:

  • Fixed IN_JoyMove doing nothing on Linux for ricochet client
  • Limited mouse thread sleep to sane values between 0 and 1000

Does not fix the following:

  • Original mouse button down/up reacting when scoreboard mouse is on bugs.

Fixes ValveSoftware#1546
- fixed m_rawinput 1 mouse trapped inside a rectangle
- fixed thirdperson camera not working as it should

Fixes ValveSoftware#1558
- recoded mousethread and made it somewhat useful for very fast mouse
  movements (will reset CursorPos now) and thus also fixed some thread
  synchronization issues (hopefully)

Further fixes:
- Fixed IN_JoyMove doing nothing on Linux for ricochet client
- Limited mouse thread sleep to sane values between 0 and 1000
@dtugend dtugend mentioned this pull request Aug 25, 2018
@dtugend
Copy link
Contributor Author

dtugend commented Aug 25, 2018

@SamVanheer
Copy link

@mikela-valve this is a common issue with all GoldSource games, would be nice to have it fixed and merged into the SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isn't mousethread somewhat pointless? m_rawinput mouse trapped inside a rectangle.
3 participants