Force libcurl.so.[34] to be taken from the Steam Runtime #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related: ValveSoftware/steam-for-linux#6224 |
|
ValveSoftware/steam-for-linux#6224 is somewhat related, but not closely. I'll comment there. |
|
The "official" SONAME of the 2012-era libcurl in Debian/Ubuntu is libcurl.so.4, so it would be enough to say To be fully compatible with 2012-era Debian/Ubuntu, we should also be creating a separate symlink |
libcurl in the Steam Runtime has a Debian-specific oddity (inherited by Ubuntu and SteamRT) in which libcurl.so.3 is a symlink to libcurl.so.4, as a result of some unfortunate ABI weirdness back in 2007 (upstream bumped the SONAME in a situation where it might not in fact have been necessary). It also has Debian-specific symbol versioning, as a result of the versioned symbols introduced as a Debian-specific change in 2005-2006 being preserved across the rename from libcurl.so.3 to libcurl.so.4 in 2007, and not matching the versioned symbols that upstream subsequently added (in 2011). Versions of Debian and Ubuntu between 2011 and 2018 (including Ubuntu 12.04, the basis for the Steam Runtime) had a patched libcurl to remain compatible with their 2007 version. In 2018, Debian and Ubuntu switched to a SONAME and versioning that match upstream, but the Steam Runtime is based on a version that is older than that, so anything built against the Steam Runtime will expect the 2007-Debian-compatible versioned symbols. Make sure we use the Steam Runtime version, which will satisfy those games' expectations. In particular, this is known to affect Risk of Rain, and perhaps other GameMaker-based games. Signed-off-by: Simon McVittie <smcv@collabora.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UNTESTED: I don't have Risk of Rain, so I don't know whether this fixes it. (It at least doesn't seem to break the Steam client...)
libcurl in the Steam Runtime has a Debian-specific oddity (inherited by
Ubuntu and SteamRT) in which libcurl.so.3 is a symlink to libcurl.so.4,
as a result of some unfortunate ABI weirdness back in 2007 (upstream
bumped the SONAME in a situation where it might not in fact have been
necessary).
It also has Debian-specific symbol versioning, as a result of the
versioned symbols introduced as a Debian-specific change in 2005-2006
being preserved across the rename from libcurl.so.3 to libcurl.so.4
in 2007, and not matching the versioned symbols that upstream
subsequently added (in 2011). Versions of Debian and Ubuntu between
2011 and 2018 (including Ubuntu 12.04, the basis for the Steam Runtime)
had a patched libcurl to remain compatible with their 2007 version.
In 2018, Debian and Ubuntu switched to a SONAME and versioning that match
upstream, but the Steam Runtime is based on a version that is older than
that, so anything built against the Steam Runtime will expect the
2007-Debian-compatible versioned symbols. Make sure we use the Steam
Runtime version, which will satisfy those games' expectations.
In particular, this is known to affect Risk of Rain, and perhaps other
GameMaker-based games.