Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vogleditor: add nested operations check #49

Merged
merged 2 commits into from
Apr 25, 2014

Commits on Apr 24, 2014

  1. vogleditor: add nested operations check

    A check is added at the "glEnd" entrypoint to ensure it doesn't get
    moved past the parent frame in the case of an unpaired glEnd(). This
    can inadvertently occur in a program and will cause a crash. (Similar
    defect in apitrace)
    
    Signed-off-by: Lawrence L Love <lawrencex.l.love@intel.com>
    lawlove committed Apr 24, 2014
    Configuration menu
    Copy the full SHA
    7ea354d View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2014

  1. vogleditor: Add for additional nest operations

    Add glPush/PopDebugGroup as nesting delimiters along with existing
    glBegin/End. Use same method as for other "vogl_is_xxx_entrypoint"
    operations.
    
    Comments:
    If this glPush/PopDebugGroup addition is (and/or possibly others are)
    accepted for nesting, another method would be to add a flag attribute
    to packets to identify apicall types that can be logically AND'd rather
    than using a switch statement (as done in apitrace).
    
    Alternatively, create a "nest" object to encapsulate this information,
    initializing it with a set of nested pairs (statically or via some
    preference) and provide an interface(s) to return needed information.
    
    Signed-off-by: Lawrence L Love <lawrencex.l.love@intel.com>
    lawlove committed Apr 25, 2014
    Configuration menu
    Copy the full SHA
    817685d View commit details
    Browse the repository at this point in the history