Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

action failing with a 403 on Alpine etc #50

Closed
ljharb opened this issue Nov 13, 2023 · 12 comments
Closed

action failing with a 403 on Alpine etc #50

ljharb opened this issue Nov 13, 2023 · 12 comments
Milestone
v3.1.0

Comments

@ljharb
Copy link

ljharb commented Nov 13, 2023

You can see this on your own actions here: https://github.com/Vampire/setup-wsl/actions/runs/6844395408/job/18608259622
@ljharb ljharb mentioned this issue Nov 13, 2023
Merged
@ljharb ljharb changed the title action failing with a 403 action failing with a 403 on Alpine etc Nov 13, 2023
@Vampire
Copy link
Owner

Vampire commented Nov 13, 2023

Yeah, I'm already looking into it.
Thanks for the issue though.
Seems something changed on the WSL distribution download sites.

@ljharb
Copy link
Author

ljharb commented Nov 13, 2023

I’d be happy to help track it down; unfortunately the action doesn’t log what URL it’s trying to download and i can’t find it in the code.

@Vampire
Copy link
Owner

Vampire commented Nov 13, 2023

This part: https://github.com/Vampire/setup-wsl/blob/master/src/main/kotlin/net/kautler/github/action/setup_wsl/Distribution.kt#L61-L71
with this argument for productId: https://github.com/Vampire/setup-wsl/blob/master/src/main/kotlin/net/kautler/github/action/setup_wsl/Distribution.kt#L438

And locally for example using HTTPie it works perfetly fine.

@Vampire
Copy link
Owner

Vampire commented Nov 13, 2023

And also using HTTPie from GitHub action machine from inside a Debian WSL distribution works fine.
And also calling that code in the action locally works fine.
It just fails when doing it in the real situation. :-/

@ljharb
Copy link
Author

ljharb commented Nov 13, 2023

Maybe they blocked some traffic that happens to target GitHub Actions?

@Vampire
Copy link
Owner

Vampire commented Nov 13, 2023

Maybe, but then why does it work from within a WSL distribution on the GHA runner?
Should probably be the same outgoing ip.

@craigloewen-msft
Copy link

From the link I saw your code is querying against the Store. You can also view the WSL distros with links to the appx files here on the WSL repo: https://github.com/microsoft/WSL/blob/master/distributions/DistributionInfo.json

@Vampire
Copy link
Owner

Vampire commented Nov 13, 2023

For most distros I use the short-links listed at https://learn.microsoft.com/en-us/windows/wsl/install-manual#downloading-distributions.
Only for those where not shortlink exists or existed when I added them, I request the link from the store.
In the course of this, I now use shortlinks for all but Alpine.
But for Alpine there is still no short-link and it is also not listed on the page you showed.
But thanks for the link anyway.

@Vampire
Copy link
Owner

Vampire commented Nov 14, 2023

I really have a hard time getting it.
I'm logged in to the running GitHub agent.
I have a Debian WSL distribution installed.
On Windows itself there is Python 3.9.13.
In the WSL Debian there is Python 3.9.2.
On both Pythons I have HTTPie 3.2.2 installed.
https://www.whois-my-ip.com/api/v1/ip returns the same for both.
But the very same HTTPie call for both http -fp HBhm POST https://store.rg-adguard.net/api/GetFiles type=ProductId url=9p804crf0395 works from WSL but fails from Windows.
The headers and body sent for both is eactly the same.
grml

@Vampire
Copy link
Owner

Vampire commented Nov 14, 2023

And also using https://echo.free.beeceptor.com instead of https://store.rg-adguard.net/api/GetFiles echoes back the exact same values, except for the date.

@Vampire
Copy link
Owner

Vampire commented Nov 14, 2023

I started a discussion at actions/runner-images#8791, maybe there someone has some idea. :-/

Vampire added a commit that referenced this issue Nov 14, 2023
@Vampire
Use permanent short-link for kali-linux (#50)
3ccaf2d
Vampire added a commit that referenced this issue Nov 14, 2023
@Vampire
Use permanent short-link for openSUSE-Leap-15.2 (#50)
406f92d
@Vampire
Copy link
Owner

Vampire commented Nov 14, 2023

I at least made a new release that fixes it for kali-linux and openSUSE-Leap-15.2 as they now have a perm-link too. But Alpine stays broken for the meantime. :-(

EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 24, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
237e913 
This undoes "Temporarily don't install WSL system to test xfail"
(dabd2fb). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 24, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
b5848ad 
This undoes "Temporarily don't install WSL system to test xfail"
(dabd2fb). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 24, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
cc20eeb 
This undoes "Temporarily don't install WSL system to test xfail"
(dabd2fb). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 25, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
71e147d 
This undoes "Temporarily don't install WSL system to test xfail"
(dabd2fb). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 25, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
c646b03 
This undoes "Temporarily don't install WSL system to test xfail"
(dabd2fb). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
EliahKagan added a commit to EliahKagan/GitPython that referenced this issue Nov 25, 2023
@EliahKagan
Put back WSL on Windows CI; pare down debug info
2875ffa 
This undoes "Temporarily don't install WSL system to test xfail"
(cabb572). It keeps Debian as the distribution. (Although the Debian
WSL system installs pretty fast already, it may still make sense to
try switching to Alpine in the future. But that might need to wait
until Vampire/setup-wsl#50 is fixed.)

This also removes most of the commands in the WSL debugging step,
since the related machinery in test_index.py (_WinBashStatus) seems
to be in okay shape, condenses the smaller number of commands that
are retained there, and makes much less extensive reduction in the
general version and platform information commands as well. This is
to make workflow output easier to read, understand, and navigate.
@ljharb ljharb mentioned this issue Nov 25, 2023
Closed
@EliahKagan EliahKagan mentioned this issue Nov 28, 2023
Merged
ljharb added a commit to ljharb/nvm that referenced this issue Dec 4, 2023
@ljharb
[Tests] temporarily allow WSL tests to fail
3e51872 
See Vampire/setup-wsl#50 / actions/runner-images#8791
@Vampire Vampire mentioned this issue May 23, 2024
Closed
Vampire added a commit that referenced this issue May 26, 2024
@Vampire
Make procuctId to URL translation work again (#50)
804f3c7
Vampire added a commit that referenced this issue May 26, 2024
@Vampire
Make procuctId to URL translation work again (#50)
cd946cd
Vampire added a commit that referenced this issue May 26, 2024
@Vampire
Make procuctId to URL translation work again (#50)
0aafe58
@Vampire Vampire added this to the Next Version milestone May 26, 2024
Vampire added a commit that referenced this issue May 27, 2024
@Vampire
Make procuctId to URL translation work again (#50)
e5717e2
@Vampire Vampire closed this as completed May 27, 2024
@EliahKagan EliahKagan mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

No branches or pull requests
3 participants
@ljharb @Vampire @craigloewen-msft