New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix embed #173

Merged

mauricewijnia merged 1 commit into VanOns:main from winkelco:patch-2

Oct 25, 2022

Contributor

winkelco commented Oct 25, 2022

There is a problem rendering youtube embeds (I imagine others too)

The problem is that the variable $this->blockName === 'core-embed' is being compared but now it seems to be called 'core-embed/youtube'

the solution is to use strpos to check if the word embed exists

this is the result


          Fix embed

4b2a1fb

Member

mauricewijnia commented Oct 25, 2022

Ah perfect, thanks for the PR!

mauricewijnia merged commit 3efbadd into VanOns:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment