Dockerize

[leonm1]

Breaking changes:

1. You must now use docker-compose up --build to build and run the container (and docker-compose up on subsequent runs). The advantage of this setup is that it only requires one command and will always produce the same result on every platform
2. .env now stores three variables, as docker-compose is hardcoded to use this file and we cannot change that:

SERVER_PORT=8080
CLIENT_PORT=8081
MONGO_PORT=27017

3. client.env now stores all the env vars for the application, and docker-compose injects them into the containers

[bencooper222]

Strongly urge that we seek feedback on this from the Slack

[leonm1]

Not yet mentioned features:

• it makes deploy a million times easier. We can set up preview deploy with one click now.
• Testing in containers is much more reliable because there are no environment difficulties

[bencooper222]

You should

• pull in the circleci config and rewrite it for docker. They haven't launched their node 12 containers yet but I'm sure it's coming. not 100% sure how it interacts with this.
• adapt the contributing.md to docker

[cktang88]

Yeah I think we should discuss this more.

It's also maybe hard to get docker to work on Windows Home and even WSL?
Might also run into networking problems with port forwarding, firewalls, etc.?

[bencooper222]

Yep, I'll try to get this working in WSL. If that works, I don't think we should let Windows Home's flaws hold us back (that's not to say there's other reasons we might not want to do this). The number of developers who lie at the intersection of "only have Windows Home" and "have a stubborn attachment to Windows Home and the Windows terminal" is very small.

[cktang88]

@leonm1 resolve conflicts?

[bencooper222]

Just realized - should .env be removed from .gitignore if it no longer has sensitive data?

[cktang88]

@leonm1 resolve conflicts so we can merge?

[leonm1]

Will do today

[bencooper222]

IMPORTANT:

• integrate with circle CI and generally make sure it doesn't fuck all that shit up

I'm actually kinda worried about this - I think there's a lot of intersecting functionality that we need to watch out for.

[stale]

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[cktang88]

Needs rebase

[bencooper222]

I don't think rebasing this is worth the time and honestly, I'd rather work on this from square one. I'll consult what you've done but I don't think I'll directly use the code you've written.