Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open android notification settings directly #25

Merged
merged 2 commits into from Jul 12, 2020

Conversation

britannio
Copy link
Contributor

Closes #24
Tested on Android Q with the example app although it's based on this answer https://stackoverflow.com/a/45192258 so it should work on most Android versions

@Vanethos
Copy link
Owner

Vanethos commented Jun 6, 2020

Thank you very much for the PR! Between today and tomorrow I’ll review it in more detail, but so far LGTM

@Vanethos Vanethos self-requested a review June 6, 2020 11:36
@britannio
Copy link
Contributor Author

Hey, @Vanethos. I forgot about this. Can you review it?

@Vanethos Vanethos self-assigned this Jul 12, 2020
@Vanethos Vanethos merged commit 6a3e469 into Vanethos:master Jul 12, 2020
@Vanethos
Copy link
Owner

Sorry for taking so long! Released version 0.4.6, thanks!

@britannio britannio deleted the android-notification-settings branch August 9, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

requestNotificationPermissions() doesn't open notification settings directly on Android
2 participants