This repository has been archived by the owner on May 16, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
It seems that for some reason, the code managed to get itself into a state where the previously applied Effects were not recognised as having already been applied. As a result, Effects were not being removed when there were duplicates if the Effect tier was the same as the previous tier, which caused massively stacking effects.
This change updates the code so that regardless of the existing tier, we always delete other Effects (there can only be one). Then we update the effect to match what the encumbrance should be.
The core part of this code is in commit 5c4dd44 which can be reviewed standalone; the remainder of the commits are simplifications to the code. I can drop these commits if you don't feel they are appropriate.