Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display alias warnings for self-defined identifiers #400

Closed
Vannevelj opened this issue Feb 19, 2016 · 1 comment
Closed

Don't display alias warnings for self-defined identifiers #400

Vannevelj opened this issue Feb 19, 2016 · 1 comment
Milestone

Comments

@Vannevelj
Copy link
Owner

When you have an enum like this:

public enum TypeCode
{
        Object = 1,
        DBNull = 2,
        Boolean = 3,
        Char = 4,
        SByte = 5,
        Byte = 6,
}

it will incorrectly suggest you to change the usages to aliases. For example this now displays a warning:

case TypeCode.Boolean:

I imagine this is the same for any self-defined type.

@Vannevelj
Copy link
Owner Author

This also presents itself here:

return _tree.Types.Single(t => t.Name == name);

Thinking this is the type Single instead. We can probably just check GetTypeInfo().SpecialType.

@Hosch250 Hosch250 self-assigned this Feb 21, 2016
@Vannevelj Vannevelj added this to the v1.9.2 milestone Feb 22, 2016
Vannevelj added a commit that referenced this issue Feb 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants