Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment in composer.json to highlight why we're using the vardot/composer-patches repo #45

Closed
moerazem opened this issue Dec 25, 2018 · 2 comments

Comments

@moerazem
Copy link
Member

No description provided.

@Natshah
Copy link
Member

Natshah commented Dec 26, 2018

Thinking of adding the following:

  "extra": {
    "_readme": [
        "Added vardot/composer-patches repository #44",
        "https://github.com/Vardot/varbase-project/issues/44",
        "As it will fix issues of deleting some modules",
        "which they do have patches over them. it will work on",
        "composer require, composer update",
        "as we have fixed issues with cweagans/composer-patches",
        "https://github.com/cweagans/composer-patches/pull/243 and more.",
        "but they still not merged yet, we went on the way of managing our own",
        "vardot/composer-patches",
        "https://github.com/Vardot/composer-patches/commits/master",
        "To follow with the latest updates, you could have a look at",
        "https://github.com/Vardot/varbase-project/blob/8.6.x/composer.json"
    ],

Natshah added a commit that referenced this issue Dec 26, 2018
Natshah added a commit that referenced this issue Dec 26, 2018
@Natshah
Copy link
Member

Natshah commented Dec 26, 2018

Thank you @moerazem for the Review and update

  "extra": {
    "_readme": [
        "NOTICE: We're now using composer patches from Vardot repository to suggest",
        "several fixes and better handling of patches in your Drupal project.",
        "You'll notice that we have included (https://github.com/vardot/composer-patches)",
        "in this composer.json repositories. This will replace the original",
        "library (cweagans/composer-patches) with our own from (vardot/composer-patches).",
        "See https://github.com/cweagans/composer-patches/pull/243 and more details",
        "on our changes on the composer-patches package. Once our changes get merged,",
        "we will revert to using (cweagans/composer-patches) without this override."
    ],

Thank you @waleedq for these fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants