Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Godot 4 #1

Merged
merged 5 commits into from
Aug 10, 2023
Merged

Conversation

OverloadedOrama
Copy link
Contributor

@OverloadedOrama OverloadedOrama commented Aug 6, 2023

Before merging this PR, I strongly suggest creating a 3.x branch, so the 3.x code can still be available for anyone that might need it.

This PR also changes the code to make better use of static typing, such as using classes instead of dictionaries. Statically typed GDScript results in increased performance in Godot 4. I did a small benchmark with the example spritesheet, by taking the average of 10 spritesheet slices. The performance increase is not that huge for the example spritesheet, but it should be noticeable with larger images.

3.x 4.x with no code changes 4.x with better static typing
233 ms 182 ms 151 ms

Known limitations:
The compatibility renderer does not yet work with multi-threaded mode (godotengine/godot#61650). Multi-threaded mode is marked as experimental in general, so use it with care, until Godot fixes the issues with it.

@Variable-ind Variable-ind merged commit 5d65d2f into Variable-Interactive:main Aug 10, 2023
@Variable-ind
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants