Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload scoreset #1

Merged
merged 5 commits into from Nov 26, 2021
Merged

Upload scoreset #1

merged 5 commits into from Nov 26, 2021

Conversation

joemin
Copy link
Contributor

@joemin joemin commented Mar 3, 2021

Another long(ish) one, but probably easier to read because it's split across many more files.
Also, the auth_token included in the example files are for a local instance of Mave so it's fine that it's hanging out in clear text.

Changes:

  • Client: a client that handles HTTP requests to a running instance of MaveDB (either deployed or local)
  • Models: a set of model objects that mirror the model objects that already exist server-side
  • Examples: an examples directory that demonstrates how to upload/download experiments and scoresets
  • Test Files: some small, basic files to test scoreset_upload

Implementation Notes:

  • I wanted the client to be agnostic of the actual models that it was serializing/deserializing from/to so all of that logic is wrapped up in the model classes.
  • Had to use attr.s instead of built-in data classes because when deserializing from JSON to instances of the models, keyword order isn't guaranteed unless we enforce it, and the data classes only take *args in their inits instead of **kwargs, which is super annoying. So, instead it's attr.s where every property has kw_only=True but... what's one to do, right?

@afrubin afrubin added this to In progress in MaveDB via automation Jun 2, 2021
@afrubin afrubin merged commit 69f3dfd into main Nov 26, 2021
MaveDB automation moved this from In progress to Done Nov 26, 2021
@afrubin afrubin deleted the upload_scoreset branch November 26, 2021 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MaveDB
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants