-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crash #6
Comments
This is bad. I have a rough idea how to solve it, but without knowing how to reproduce it, I can't promise the fix will actually work. I'll do my best though. |
If I had any plausible hint at how to reproduce it, I would have given it, but the crash caught me off-guard, I didn't paid attention to what I did... |
The stack trace sure helped. A possible reason is a new creature arriving
just while the party selector iterated the creature list.
There is a suggested pattern to prevent this, iterate on a copy of the
list. I've applied this pattern now, so with some luck, this crash should
not happen in v0.26 anymore.
Morel Bérenger ***@***.***> schrieb am Di., 7. Nov. 2023,
20:10:
… If I had any plausible hint at how to reproduce it, I would have given it,
but the crash caught me off-guard, I didn't paid attention to what I did...
—
Reply to this email directly, view it on GitHub
<#6 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOZTXX4S7OWYCP2DLAMELRLYDKBUDAVCNFSM6AAAAAA7BDY5W2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJZGYZTSNJTHA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I hope I could fix this in v0.26 but since I could not reproduce it, I had no way to test if the fix actually works. I'll keep this issue open and see if more reports come in. |
The text was updated successfully, but these errors were encountered: