-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Composer provisioner seems to be partially failing #2573
Comments
@ssnepenthe can you be more specific? I've tried looking through the logs but the only clue i have is |
Yeah sorry about that... I was referring to this: https://github.com/Varying-Vagrant-Vagrants/VVV/blob/dc28ec9fa53a4cab46d3857ce58cb2eeaec52f00/provision/core/composer/provision.sh I did not see any errors or warnings, or really any indication that anything is wrong or failing. However, once provisioning has finished if I run When I look through that provisioner file it seems to be succeeding up through line 21. Composer is installed at /home/vagrant/composer.phar and has been given execute permissions. Nothing after that seems to have run. For example I would assume that we should see more about composer in the ouput log such as "Composer installer steps completed" and "Making sure the Composer cache is not owned by root" but these entries are missing. |
So |
Does this PR result in more information? #2574 |
That's fair... Sorry if I haven't been very clear or helpful I'm just not really sure I know how else to approach this issue beyond "it doesn't seem to be working as expected..." I am re-provisioning now with that PR and will get back to you. |
|
The contents of the actual log file at
|
looks like I forgot to wrap it in square brackets. I notice WP CLI updating has issues though. I've committed a fix for the |
As for the composer installer, it's just figuring out downloading |
I've also changed the move command to report if that failed or not |
Interesting... I've now re-provisioned three times with the latest from #2574 with slightly different results each time. Relevant output from the three runs is below. The first time the issue was still occurring. The second time composer was installed correctly. It also seems to be correctly checking for github tokens and composer updates. The third time composer was installed correctly again but there is nothing about github tokens or composer updates. FIRST:
SECOND:
THIRD:
|
what do the log files say? Not everything gets printed to the terminal |
FIRST:
SECOND:
THIRD:
|
@ssnepenthe I've made a number of improvements to logging etc, including better network checks. I've also moved the Grunt gyp loop hack out into a non-parallelised provisioner. Can you check if things are improved on that PR? |
Just tested the PR with a fresh provision and then a reprovision and everything seems to be working, thanks! |
@ssnepenthe now that it's been merged are we good to close this? I've created #2580 to handle the |
What was The Command Used To Provision
What Kind of VVV Provision Was This
This was a fresh install
Logs/What Broke
Not really sure what to do with this - It has happened twice in a row.
Composer is successfully installed to /home/vagrant and given execute permission.
It seems like the provisioner is failing while trying to change ownership of files in /usr/local/bin. Nothing after this line in the provisioner function is running.
Steps to Reproduce (for bugs)
Provisioning output: https://gist.github.com/ssnepenthe/5efa946668b900ba4808e7cbe98dbf21
Your Environment
Operating System: Windows 11
Vagrant Version: 2.2.19
Virtualbox Version: 6.1.32
The text was updated successfully, but these errors were encountered: