Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Mailcatcher with Mailhog in README.md. #1684

Merged
merged 1 commit into from Dec 16, 2018
Merged

Replace Mailcatcher with Mailhog in README.md. #1684

merged 1 commit into from Dec 16, 2018

Conversation

fabacab
Copy link
Contributor

@fabacab fabacab commented Dec 14, 2018 •
edited

Summary:

New installations of VVV will install Mailhog, not Mailcatcher. The project's README file should reflect this.

Checks

  • I've tested this PR with Vagrant v2.2.2 and VirtualBox v5.2.22 on macOS
  • This PR is for the develop branch not the master branch
  • I've updated the changelog (actually, I've made the README match the Changelog. ;)
  • This PR is complete and ready for review

@fabacab
Replace Mailcatcher with Mailhog in README.md.
4be29e0 
New installations of VVV will install Mailhog, not Mailcatcher. The
project's README file should reflect this.
@Mte90 Mte90 requested review from Mte90 and tomjn December 15, 2018 13:27
@tomjn tomjn merged commit 3536a2c into Varying-Vagrant-Vagrants:develop Dec 16, 2018
@tomjn
Copy link
Member

tomjn commented Dec 16, 2018

Thanks!!

@fabacab fabacab deleted the mailhog-readme branch December 16, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mte90 Mte90 Mte90 approved these changes

@tomjn tomjn Awaiting requested review from tomjn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabacab @tomjn @Mte90