Add nginx default pages, #1846

[Mte90]

#1846

Checks

• I've updated the changelog.
• I've tested this PR
• This PR is for the develop branch not the stable branch.
• This PR is complete and ready for review.

[update-docs]

Thanks for opening this pull request! Make sure CHANGELOG.md gets updated with this change, additionally any docs that need updated can be found at https://github.com/Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

GitHub

Varying-Vagrant-Vagrants/varyingvagrantvagrants.org

The VVV docs and website. Contribute to Varying-Vagrant-Vagrants/varyingvagrantvagrants.org development by creating an account on GitHub.

[Mte90]

As it is now there is no crash but I don't know how to test it and get a 403 as example.

[tomjn]

Ideally we use css grid or flexbox to center the box vertically and horizontally, then give it a max width close to 600px

[Mte90]

I copied the css from the dashboard but is so minimal that page that is required to use flexbox?

[tomjn]

not so much for minimalism but for aesthetics, making it centered vertically will be difficult without flex or grid

[tomjn]

Just noting I want to make some wording changes to avoid general errors being misconstrued as VVV specific errors

[tomjn]

I'm unable to get this to work, I turned off the PHP service and got this instead of the custom 502 page:

[tomjn]

@Mte90 I wanted to make changes to the pages themselves but I've not been able to get any of this to work, I don't know the relevant changes to the NGINX config to make this work and the various things i've tried on stackoverflow have made no difference

[tomjn]

https://blog.adriaan.io/one-nginx-error-page-to-rule-them-all.html may hold the best approach it'd allow for a single html file too

I'm mindful right now all requests are handled by the dashboard or by sites, or custom extensions like tideways stuff

One NGINX error page to rule them all · Adriaan's blog

[tomjn]

@Mte90 that article was what was needed, I refactored things and they work as expected, the easiest ways to test are:

• to visit http://vvv.test/doesnotexist.php to see a 404
• turn off the PHP service then load a site that uses that service to see a 502 gateway error

I also removed references to VVV itself so that people don't assume this is our fault first, this is an Nginx generic HTTP code page, I also threw in 2 links to MDN and http statuscodes so they have somewhere to go to find out more

[tomjn]

Minor styling changes and changelog updated:

[Mte90]

we need a review from @evertiro or @msaggiorato

[tomjn]

Those are in the main http block, this part needs to be added to the server blocks in several places though

…

On Tue, 30 Nov 2021 at 11:32, Matias Saggiorato ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In provision/core/nginx/config/nginx-wp-common.conf <#2345 (comment)> : > @@ -7,6 +7,14 @@ # include /etc/nginx/nginx-wp-common.conf; # # See local-nginx-example.conf-sample for a full example + +location = /error.html { + ssi on; + internal; + auth_basic off; + root /usr/share/nginx/html; +} Aren't we missing the error_page setting here with all the error codes we're catching? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#2345 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAOLZ7TRXBDJO65BGKXPKDUOSY5BANCNFSM4WVKBNYA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[msaggiorato]

Looks good after a new look at the code (I was originally confused about the error_page setting which i thought was only set in one of the server blocks, but it's actually in the http block, which superseeds all server blocks, so we're good.