Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BCMath PHP Extension #977

Merged
merged 1 commit into from Oct 21, 2016
Merged

Add BCMath PHP Extension #977

merged 1 commit into from Oct 21, 2016

Conversation

LoreleiAurora
Copy link
Contributor

Fixes #944

khromov
khromov suggested changes Sep 19, 2016
View reviewed changes
Copy link
Contributor

@khromov khromov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thus also seems to add the ssh2 package, is that intentional?

@LoreleiAurora
Copy link
Contributor Author

@khromov It appears that way but the ssh2 module is already in master, in that exact position. 😕

@khromov
Copy link
Contributor

khromov commented Sep 19, 2016

I see. There's something really funky going on in this repo. One of my pull requests suddenly got unrelated commits added to it. 😩

cfoellmann
cfoellmann approved these changes Oct 11, 2016
View reviewed changes
Copy link
Member

@cfoellmann cfoellmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provision runs as expected. no hick-ups generated by this. No big potential for breaks anyway.

@jeremyfelt jeremyfelt added this to the Next Release milestone Oct 21, 2016
@jeremyfelt
Copy link
Member

Thanks @LoreleiAurora! And thanks @cfoellmann for testing! :)

@jeremyfelt jeremyfelt merged commit a1d771f into Varying-Vagrant-Vagrants:develop Oct 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khromov khromov khromov requested changes

@cfoellmann cfoellmann cfoellmann approved these changes

Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LoreleiAurora @khromov @jeremyfelt @cfoellmann