Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] company_country: improve how we process country code #142

Merged

Conversation

umiphos
Copy link

@umiphos umiphos commented Sep 19, 2018

This PR is in order to validate the country configuration of the localization. This change is for odoo-sh.

This change will take into account the localization that is set in the pool of apps to install.
This change is for the environments where we haven't set the COUNTRY Variable in the installation pool.

image

@coveralls
Copy link

coveralls commented Sep 19, 2018

Coverage Status

Coverage decreased (-0.6%) to 83.969% when pulling 9c7dfa4 on vauxoo-dev:11.0-search_country_localization-umiphos into bf96d2c on Vauxoo:11.0.

@codecov-io
Copy link

codecov-io commented Sep 19, 2018

Codecov Report

Merging #142 into 11.0 will decrease coverage by 0.64%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             11.0     #142      +/-   ##
==========================================
- Coverage   84.61%   83.96%   -0.65%     
==========================================
  Files           9        9              
  Lines         390      393       +3     
==========================================
  Hits          330      330              
- Misses         60       63       +3
Impacted Files Coverage Δ
company_country/models/res_config.py 66.66% <0%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf96d2c...62d58f5. Read the comment docs.

@umiphos umiphos force-pushed the 11.0-search_country_localization-umiphos branch 2 times, most recently from e7d8552 to b1e7887 Compare September 19, 2018 16:08
- Under settings go to **Module installation**
- Write down the modules you want to install, but make sure the localization is in that line along with the module you want to install

.. image:: https://user-images.githubusercontent.com/4094256/45761834-a8024180-bbf2-11e8-807d-9d1d7dfcd3a8.png

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

company_country,module_app

@umiphos umiphos force-pushed the 11.0-search_country_localization-umiphos branch from b1e7887 to 9c7dfa4 Compare September 19, 2018 18:00
@moylop260 moylop260 merged commit 90b5797 into Vauxoo:11.0 Sep 30, 2018
@moylop260 moylop260 deleted the 11.0-search_country_localization-umiphos branch September 30, 2018 08:10
moylop260 pushed a commit that referenced this pull request Oct 31, 2018
luistorresm pushed a commit to vauxoo-dev/server-tools that referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants