Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Manual Morph #28 and Fix #29 #30 #33

Merged
merged 8 commits into from
Jan 9, 2019

Conversation

MoreThanHidden
Copy link
Contributor

@MoreThanHidden MoreThanHidden commented Dec 8, 2016

-Added Manual Morph on Shift + Scroll #28
-Added Server Client Network Message #30

@Alex-hawks
Copy link

I'm going to be that guy and say that you should squash your commits

@MoreThanHidden
Copy link
Contributor Author

Damn Squashing with a Merge is annoying, and yes, I'd rather not do it again to fix that typo 😒

@ghost
Copy link

ghost commented Mar 16, 2017

How do I morph manually? Shift + scrolling doesn’t do anything.

@flapili flapili mentioned this pull request Jul 18, 2017
@MoreThanHidden
Copy link
Contributor Author

Thought I might have messed something up with the squash, but no its still working.
Sneak + Scroll:
manualmorph

Modified to actually compile and work with latest AutoRegLib and Forge
@MoreThanHidden
Copy link
Contributor Author

Updated to 1.12 with latest AutoRegLib

@MoreThanHidden
Copy link
Contributor Author

@Vazkii if you could check out this PR when you get a chance, let me know if you want any changes or if you don't think it suits.

Compiled Version if that helps:
Unofficial-Morph-o-Tool-1.2-PR#33.zip

@Vazkii
Copy link
Member

Vazkii commented Aug 1, 2017

I'll have a look after I'm back from my break. I don't want to have to support any potential bugs this causes.

@Segaja
Copy link

Segaja commented Apr 28, 2018

Is there any chance to get this merged at some point? I'm a victim of #30 and would love to see that fixed.

@TheDeviantCrafter
Copy link

I'd also like to see this merged. It would be especially useful for packs that didn't bother to add aliases in the config file. By default, it doesn't work with Buildcraft very well for example.

@Arudarin
Copy link

Any news?

Merged upstream changes, added Auto Reg Lib dependency and tested.
Increase Priority so Yeta or other sneak+scroll wrenches arn't preferred unless looking at the block.
@MoreThanHidden
Copy link
Contributor Author

@Vazkii have been using my Fork on Enigmatica 2 Expert without issue, if you don't have time to take a look could I release these changes as an unofficial fork?

@Vazkii Vazkii merged commit da2f8e0 into VazkiiMods:master Jan 9, 2019
@Vazkii
Copy link
Member

Vazkii commented Jan 9, 2019

Took me way too long to get this merged. Nonetheless it's in now, thank you for the insane patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants