Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid Intel specific flags with icc #322

Merged
merged 2 commits into from May 5, 2022
Merged

Conversation

bernhardmgruber
Copy link
Collaborator

No description provided.

@amadio
Copy link
Collaborator

amadio commented Apr 8, 2022

Can you please rebase this and replace all "/SSE2" with ""?

@bernhardmgruber
Copy link
Collaborator Author

Do you mean the /arch:SSE2 flags? Those are for MSVC. What is the problem with them?

@amadio
Copy link
Collaborator

amadio commented Apr 8, 2022

Yes, that's what I mean. They are not necessary (enabled by default on x86), or not available (only AVX and above for x64).

@bernhardmgruber
Copy link
Collaborator Author

Oh, I did not know it was the default on 32bit VS as well. Will do!

@amadio
Copy link
Collaborator

amadio commented May 3, 2022

I think it's only uploading to CDash that is failing. Maybe we should just disable that temporarily to get the actual results in CI?

@bernhardmgruber bernhardmgruber force-pushed the nointel branch 3 times, most recently from 1902e07 to c5429ab Compare May 4, 2022 14:22
@bernhardmgruber
Copy link
Collaborator Author

I think I found the issue. icpc does nether recognize the flags -mavx2 nor -mbmi2. You have to pass -march=core-avx2 to enable AVX2. It's described here: https://www.intel.com/content/www/us/en/develop/documentation/cpp-compiler-developer-guide-and-reference/top/compiler-reference/compiler-options/compiler-option-details/code-generation-options/m.html

@bernhardmgruber
Copy link
Collaborator Author

bernhardmgruber commented May 4, 2022

icpc: error #10106: Fatal error in /opt/intel/oneapi/compiler/2022.0.2/linux/bin/intel64/../../bin/intel64/mcpcom, terminated by kill signal
compilation aborted for /home/runner/work/Vc/Vc/tests/utils.cpp (code 1)

But all other tests for Intel are passing.

SSE2 is enabled by default in Visual Studio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants