Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bookmark/Tags context menu is inconsistent #3130

Closed
yrp604 opened this issue May 16, 2022 · 1 comment
Closed

Bookmark/Tags context menu is inconsistent #3130

yrp604 opened this issue May 16, 2022 · 1 comment
Assignees
@jonpalmisc
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround
Milestone
3.1 (Performance)

Comments

@yrp604
Copy link
Contributor

yrp604 commented May 16, 2022

Version and Platform (required):

  • Binary Ninja Version: 2.4.3427
  • OS: Windows
  • OS Version: 11
  • CPU Architecture: x64

Bug Description:
A bookmark is a subtype of tag, but the top level menu entry is "bookmark", inverting the relationship between the concepts.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Right click
  2. See "Bookmark"
  3. See error

Expected Behavior:
I expect Tags to be the top level entry with Bookmark as a subtype. Alternatively, because there are convenient key binds for bookmarks they could be removed and the entire menu could just be flattened into 'Add Tag'.
@jonpalmisc
Copy link
Contributor

Will be fixed in builds ≥3436.

@jonpalmisc jonpalmisc self-assigned this May 17, 2022
@jonpalmisc jonpalmisc added Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels May 17, 2022
@psifertex psifertex added this to the 3.1 (Performance) milestone May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonpalmisc jonpalmisc

Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround
Projects
None yet
Milestone
3.1 (Performance)
Development

No branches or pull requests
3 participants
@psifertex @yrp604 @jonpalmisc