Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have the prototypes exactly the same as their definition in SDK /WDK #4829

Open
op2786 opened this issue Dec 14, 2023 · 1 comment
Open

Have the prototypes exactly the same as their definition in SDK /WDK #4829

op2786 opened this issue Dec 14, 2023 · 1 comment
Labels
Component: Type Libraries Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@op2786
Copy link
Contributor

op2786 commented Dec 14, 2023

I'm opening this issue with windows kernel support in my mind, but I guess my point is acceptable for all platforms. I strongly believe that we should have the function prototypes exactly the same as their definition in the SDK.

For example, according to the prototype in the WDK, KeAcquireSpinLockRaiseToDpc returns KIRQL but BN tells me it returns uint64_t. Even if it is technically correct, it causes several other neurons to fire and disrupting integrity of the understanding process. Because now I need to remember (or worst, look it up) what does KeAcquireSpinLockRaiseToDpc returns. Seeing a KIRQL as a return type there could make me understand (or at least guess) that it returns current IRQL.
@xusheng6 xusheng6 added Type: Enhancement Issue is a small enhancement to existing functionality Impact: Low Issue is a papercut or has a good, supported workaround Effort: Low Issue should take < 1 week Component: Type Libraries labels Jan 3, 2024
@xusheng6 xusheng6 mentioned this issue Jan 3, 2024
Open
@plafosse plafosse self-assigned this Jan 9, 2024
@plafosse plafosse added this to the Dorsai milestone Jan 9, 2024
@op2786
Copy link
Contributor Author

op2786 commented Jan 29, 2024

Those two function actually returns DWORD.

@plafosse plafosse modified the milestones: Dorsai, Elysium Feb 8, 2024
@plafosse plafosse removed their assignment Jun 13, 2024
@plafosse plafosse modified the milestones: Elysium, Fhloston Jun 18, 2024
@plafosse plafosse removed this from the Frogstar milestone Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Type Libraries Effort: Low Issue should take < 1 week Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@plafosse @xusheng6 @op2786