Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report Template Update #496

Merged
merged 16 commits into from
Nov 6, 2023
Merged

Report Template Update #496

merged 16 commits into from
Nov 6, 2023

Conversation

a-kore
Copy link
Collaborator

@a-kore a-kore commented Nov 3, 2023

Feature

Short Description

  • Add Overview section to model card schema
    • Section with summary of overall metrics (historical+current)
    • Section with summary of breakdown of metrics too choose splits/metrics to analyze
  • Add MetricCard and MetricCardCollection to model card schema to facilitate overview section.
  • Add tooltips for description of metric.

Tests Added

No tests added.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #496 (533fe36) into main (d9a6258) will increase coverage by 0.60%.
Report is 1 commits behind head on main.
The diff coverage is 68.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   61.36%   61.96%   +0.60%     
==========================================
  Files          86       86              
  Lines        8257     8435     +178     
==========================================
+ Hits         5067     5227     +160     
- Misses       3190     3208      +18     
Files Coverage Δ
cyclops/monitor/detector.py 56.98% <ø> (ø)
cyclops/report/model_card/fields.py 79.72% <100.00%> (+2.63%) ⬆️
cyclops/report/model_card/model_card.py 62.96% <100.00%> (+1.42%) ⬆️
cyclops/report/model_card/sections.py 100.00% <100.00%> (ø)
cyclops/data/loader.py 0.00% <0.00%> (ø)
cyclops/report/report.py 26.04% <10.71%> (+3.91%) ⬆️
cyclops/report/utils.py 77.08% <74.00%> (-7.37%) ⬇️

... and 3 files with indirect coverage changes

Impacted file tree graph

@amrit110 amrit110 requested a review from fcogidi November 3, 2023 19:10
cyclops/report/model_card/fields.py Show resolved Hide resolved
cyclops/report/model_card/fields.py Outdated Show resolved Hide resolved
cyclops/report/utils.py Outdated Show resolved Hide resolved
@amrit110 amrit110 added the enhancement New feature or request label Nov 6, 2023
@a-kore a-kore merged commit 3d8283f into main Nov 6, 2023
9 checks passed
@a-kore a-kore deleted the report_baseline_comparison branch November 6, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants