Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyarrow version, use pyarrow backend for pandas #513

Merged
merged 5 commits into from
Nov 27, 2023
Merged

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Nov 24, 2023

PR Type ([Feature | Fix | Documentation | Test])

Update

Short Description

  • Update pyarrow version, also use pyarrow backend as default for pandas

Tests Added

...

@amrit110 amrit110 self-assigned this Nov 24, 2023
@amrit110 amrit110 added the documentation Improvements or additions to documentation label Nov 24, 2023
@amrit110 amrit110 assigned fcogidi and amrit110 and unassigned amrit110 and fcogidi Nov 24, 2023
@amrit110 amrit110 added enhancement New feature or request update Updating dependencies and removed enhancement New feature or request labels Nov 24, 2023
@amrit110 amrit110 changed the title Update pyarrow version, los prediction notebook Update pyarrow version, use pyarrow backend for pandas Nov 27, 2023
@amrit110
Copy link
Member Author

@fcogidi, I've switched to using pyarrow backend for pandas. In the cyclops-query tool, i also set the default backend of the pandas df returned to be pyarrow. This caused some errors in the tests. Can you please take a look? I want to migrate to using pyarrow backend since that would make the dataframe easily convertible between dataframe libraries and also into HF dataset.

@fcogidi
Copy link
Collaborator

fcogidi commented Nov 27, 2023

@fcogidi, I've switched to using pyarrow backend for pandas. In the cyclops-query tool, i also set the default backend of the pandas df returned to be pyarrow. This caused some errors in the tests. Can you please take a look? I want to migrate to using pyarrow backend since that would make the dataframe easily convertible between dataframe libraries and also into HF dataset.

I'll take a look.

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #513 (3399546) into main (b4a94c6) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #513   +/-   ##
=======================================
  Coverage   64.21%   64.21%           
=======================================
  Files          94       94           
  Lines        9302     9303    +1     
=======================================
+ Hits         5973     5974    +1     
  Misses       3329     3329           
Files Coverage Δ
cyclops/data/slicer.py 85.77% <100.00%> (+0.06%) ⬆️
cyclops/process/feature/handle_types.py 79.91% <100.00%> (ø)

Impacted file tree graph

@amrit110 amrit110 merged commit 6eb4e9c into main Nov 27, 2023
8 checks passed
@amrit110 amrit110 deleted the update_pyarrow branch November 27, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation update Updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants